Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor toJS for mobx4 #1733

Merged
merged 2 commits into from
Sep 28, 2018

Conversation

wangyiz4262
Copy link
Contributor

PR checklist:

  • Added unit tests
  • Updated change log
  • Verified that there is no significant performance drop (npm run perf)

toJS will recursively convert an object containing Mobx observable value into a plain object

@coveralls
Copy link

coveralls commented Sep 21, 2018

Coverage Status

Coverage increased (+0.1%) to 92.677% when pulling c18b74a on wangyiz4262:refactor-tojs-mobx4 into 57ae8d2 on mobxjs:mobx4-master.

@wangyiz4262 wangyiz4262 changed the title Recursively convert mobx observable to plain object with an optional … Refactor toJS for mobx4 Sep 21, 2018
@wangyiz4262 wangyiz4262 mentioned this pull request Sep 28, 2018
3 tasks
@mweststrate mweststrate merged commit 952e4a8 into mobxjs:mobx4-master Sep 28, 2018
@stnwk
Copy link

stnwk commented Oct 16, 2018

When will this be published? 🙈☺️ @mweststrate

@mweststrate
Copy link
Member

mweststrate commented Oct 16, 2018 via email

@stnwk
Copy link

stnwk commented Oct 16, 2018

Thanks!

@wangyiz4262 wangyiz4262 deleted the refactor-tojs-mobx4 branch October 23, 2018 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants