implement observable set #1592
Closed
implement observable set #1592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@newraina just wondering, what's left to implement this feature? |
|
@xaviergonz doc and changelog update in the PR checklist... sorry for delay so long |
|
@newraina if that's the only thing that's left I could lend you a hand if you want |
|
@xaviergonz |
|
Apologies for the late follow up! The PR went unnoticed as it seemed the build was still failing. Thanks for the awesome PR and will process it further! |
|
Can't there be a threshold before coveralls marks a PR as failing? |
|
Merging, thanks a lot! |
|
Fixed and released in 4.9.0 / 5.9.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to the issue: #69
PR checklist:
gh-pagesbranch. Please refer to this PR). For new functionality, at least API.md should be updatednpm run perf)