Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace the memorizer from array to ES6 map in mobx.tojs() #1517

Merged
merged 1 commit into from
May 3, 2018
Merged

refactor: replace the memorizer from array to ES6 map in mobx.tojs() #1517

merged 1 commit into from
May 3, 2018

Conversation

loatheb
Copy link
Contributor

@loatheb loatheb commented Apr 23, 2018

refactor: replace the memorizer from array to ES6 map in mobx.tojs() & extract the common cache method from recursion

Thanks for taking the effort to create a PR!

If you are creating an extensive PR, you might want to open an issue with your idea first, so that you don't put a lot of effort in an PR that wouldn't be accepted. Please prepend pull requests with WIP: if they are not yet finished
PR checklist:

  • Added unit tests
  • Updated changelog
  • Updated docs (either in the description of this PR as markdown, or as separate PR on the gh-pages branch. Please refer to this PR). For new functionality, at least API.md should be updated
  • Added typescript typings
  • Verified that there is no significant performance drop (npm run perf)

Feel free to ask help with any of these boxes!

The above process doesn't apply to doc updates etc.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 92.972% when pulling 7d167ef on loatheb:refactor-tojs into dbe4c93 on mobxjs:master.

@mweststrate
Copy link
Member

Thanks!

@mweststrate mweststrate merged commit 6b50a8c into mobxjs:master May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants