Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid the unnecessary reassign with the equivalent comparison result #1499

Merged
merged 2 commits into from
Apr 16, 2018

Conversation

kuitos
Copy link
Member

@kuitos kuitos commented Apr 13, 2018

Now the computed value will be reassign although the assignment was equivalent by the comparer.

@mweststrate
Here is the jsfiddle demo which describes the unexpected behavior, or u can check the added unit test for details🙂

  • Added unit tests
  • Updated changelog
  • Updated docs (either in the description of this PR as markdown, or as separate PR on the gh-pages branch. Please refer to this PR). For new functionality, at least API.md should be updated
  • Added typescript typings
  • Verified that there is no significant performance drop (npm run perf)

@coveralls
Copy link

coveralls commented Apr 13, 2018

Coverage Status

Coverage increased (+0.05%) to 92.983% when pulling cff477c on kuitos:fork-master into 7179b96 on mobxjs:master.

@mweststrate
Copy link
Member

Thanks! This makes a lot of sense :-). Thanks for catching and fixing

@mweststrate mweststrate merged commit f6df576 into mobxjs:master Apr 16, 2018
@mweststrate
Copy link
Member

Released as 4.2.0

@kuitos kuitos deleted the fork-master branch April 17, 2018 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants