enforceActions still allows to modify observers out of action scope

[the-fedorr]

When i configure configure({enforceActions: true});, i expect that it does what it have to: doesn't allow state modifications outside of actions.

But after creation observable (i use, for example, extendObservable) i can directly change the observable's values.

Digging the code source code, i found that function checkIfStateModificationsAreAllowed checks not only allowStateChanges (what is "true" if i'm inside of action), but also detect's the atom's observers length, and if there is no observers - it ignores configuration enforceActions and allowStateChanges.

In my project it causes that i can modify store whenever i want, until React component is being rendered. After that store is getting an observer (React component) and checkIfStateModificationsAreAllowed stops allowing me to modify the store. Looks strange, don't it?

I believe what you call "strict" mode should be really strict. Or, at least we could have an option to set "strict-strict" mode.

Also provide the source code i talk about:

function checkIfStateModificationsAreAllowed(atom) {
    var hasObservers$$1 = atom.observers.length > 0;
    // Should never be possible to change an observed observable from inside computed, see #798
    if (globalState.computationDepth > 0 && hasObservers$$1)
        fail$1(process.env.NODE_ENV !== "production" &&
            "Computed values are not allowed to cause side effects by changing observables that are already being observed. Tried to modify: " + atom.name);
    // Should not be possible to change observed state outside strict mode, except during initialization, see #563
    if (!globalState.allowStateChanges && hasObservers$$1)
        fail$1(process.env.NODE_ENV !== "production" &&
            (globalState.enforceActions
                ? "Since strict-mode is enabled, changing observed observable values outside actions is not allowed. Please wrap the code in an `action` if this change is intended. Tried to modify: "
                : "Side effects like changing state are not allowed at this point. Are you trying to modify state from, for example, the render function of a React component? Tried to modify: ") +
                atom.name);
}

[pavanpodila]

I am noticing this as well. As suggested by @the-fedorr, this behavior should be guarded even when there are no observers. This will keep it more consistent.

[mweststrate]

See https://github.com/mobxjs/mobx/blob/master/CHANGELOG.md#improved-strict-mode for some background of the current behavior

[kunlongxu]

@the-fedorr @mweststrate
I encountered the same problem, no matter where I put this code, it does not take effect
configure({ enforceActions: true });
How I can do?

[mweststrate]

@linmodev by default mobx won't complain about the lack of actions if the observables are not observed yet. In the next minor, it will also be possible to set enforceActions: "strict" to make it even throw in these cases (so this is more strict then true)

[mweststrate]

Released enforceActions: "strict" as 4.2.0

[whs]

I'm running into #338 with the new strict mode enabled.

[mweststrate]

Yes, that is totally expected, and one of the reason it was relaxed in the first place. So, pick your poison :-). Use runInAction or make the thing that calls the constructor an action. Op di 17 apr. 2018 om 09:12 schreef Manatsawin Hanmongkolchai < [email protected]>:

…

I'm running into #338 <#338> with the new strict mode enabled. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#1473 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABvGhH9N3gFG3fZRuo73i8CPpSp7cl9mks5tpZXXgaJpZM4TCLWx> .

[urugator]

I suggest to change the available options to:
"never", "always", "observed"
(to remain BC "observed" <=> true, "always" <=> "strict", "never" <=> false)

[mweststrate]

In MobX 4.4 / 5.1 the config values have changed to never, observed and always