Fix/2230 type instantiation excessively deep #2231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thegedge
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Verified failing before and fixed after
Thanks for fixing, @coolsoftwaretyler <3 🙇
coolsoftwaretyler
deleted the
fix/2230-type-instantiation-excessively-deep
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do and why?
Fixes #2230 by using mapped types instead of
Omit. Seems to pass the test case.Steps to validate locally
You should not see TS errors about excessively deep type instantiation. All other tests and type checks should work.