Typing self in actions and views: documentation advices poorly performing way

[k-g-a]

In the documentation:
https://github.com/mobxjs/mobx-state-tree/tree/v2.0.5#typing-self-in-actions-and-views
it's said that one can use local "views" variable to refer a prop:

const views = {
    get upperProp(): string {
        return self.prop.toUpperCase();
    },
    get twiceUpperProp(): string {
        return views.upperProp + views.upperProp;
    }
  }

However, accessing such computed values (e.g. inside render method of an observed component) always leads to full recompute. This is easily prooved by tracing those properties.
Tracer says:

[mobx.trace] 'PROP NAME' is being read outside a reactive context. Doing a full recompute

Which is true, because 'views' object itself is not observed, but properties are copied to 'self' during instance initialization.

This leads to performance drop as every such property is recomputed on every re-render.
Should we add a warning to the documentation or completely remove it in favor of

const Example = types
    .model({
        prop: types.string
    })
    .views(_self => {
        const self = _self as IExample;
        return {
            get upperProp(): string {
                return self.prop.toUpperCase();
            },
            get twiceUpperProp(): string {
                return self.upperProp + self.upperProp;
            }
        };

    });

type ExampleType = typeof Example.Type;
interface IExample extends ExampleType {}

[mweststrate]

Good catch! would you mind updating the readme?

[k-g-a]

Of course. Should I add a warning to existing example, provide the one from comment above or do both?

[mweststrate]

I think both. If it get's too long maybe put it in a separate md file in docs. (the whole TS section). Thanks in advance! Op ma 18 jun. 2018 om 17:13 schreef Gleb <[email protected]>:

…

Of course. Should I add a warning to existing example, provide the one from comment above or do both? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#818 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABvGhGX70k9Cvf8i6-8GizTBkX-fGA8Nks5t98N8gaJpZM4T_UKW> .