some UX improvements, very hackish #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hi, the first change is * a click on the canvas now leads to a paint, without any mousemove - feels more responsive * user can leave the canvas for a moment (500 ms) and come back in to continue drawing (it was kind annoying that if you wanted to draw the whole canvas, that when you accidentally left the canvas, you had to click to start drawing again) i implemented it very hackish directly into the JS, if you want to reuse the logic you will have to write it in coffee great lib otherwise, thx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi, the first change is
* a click on the canvas now leads to a paint, without any mousemove - feels more responsive
* user can leave the canvas for a moment (500 ms) and come back in to continue drawing (it was kind annoying that if you wanted to draw the whole canvas, that when you accidentally left the canvas, you had to click to start drawing again)
i implemented it very hackish directly into the JS, if you want to reuse the logic you will have to write it in coffee
great lib otherwise, thx