Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse target and profile from out dir #12

Merged
merged 3 commits into from
Apr 4, 2023
Merged

Parse target and profile from out dir #12

merged 3 commits into from
Apr 4, 2023

Conversation

varsha888
Copy link
Contributor

@varsha888 varsha888 commented Mar 27, 2023 •
edited
Loading

Fix for Issue:

Parse target dir from either of the below mentioned in the given order,

  1. target type
  2. target dir from "CARGO_TARGET_DIR"
  3. "target" string

Get profile dir from target dir

@github-actions github-actions bot added rust Pull requests that update rust code size/L Large PRs labels Mar 27, 2023
@github-actions github-actions bot added size/XL Extra-Large PRs and removed size/L Large PRs labels Mar 27, 2023
@github-actions github-actions bot added size/L Large PRs and removed size/XL Extra-Large PRs labels Mar 27, 2023
@github-actions github-actions bot added the github_actions Pull requests that update github actions label Mar 27, 2023
@varsha888 varsha888 self-assigned this Mar 27, 2023
@varsha888 varsha888 marked this pull request as ready for review March 27, 2023 19:57
@varsha888 varsha888 requested a review from jcape as a code owner March 27, 2023 19:57
@varsha888 varsha888 requested a review from NotGyro March 27, 2023 19:57
NotGyro
NotGyro approved these changes Mar 28, 2023
View reviewed changes
Copy link

@NotGyro NotGyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@varsha888 varsha888 merged commit 3573b1e into main Apr 4, 2023
@varsha888 varsha888 deleted the bug branch April 4, 2023 16:57
@jcape jcape mentioned this pull request Apr 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotGyro NotGyro NotGyro approved these changes

@jcape jcape jcape approved these changes

Assignees

@varsha888 varsha888

Labels
github_actions Pull requests that update github actions rust Pull requests that update rust code size/L Large PRs
Projects
Core PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@varsha888 @jcape @NotGyro