Portability: restore check for system OpenSSL libraries #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FreeBSD, OpenBSD, and I think NetBSD all have OpenSSL as part of the base OS. Since they are not packages they don't have .pc files and won't be detected by PKG_CHECK_MODULES(). Restore the explicit detection of these system libraries lost in commit bacc024.
Found by OpenBSD 6.0 make.
|
I believe the removal of this AX_CHECK_LIBRARy was intentional. @bbarenblat can you please take a look? |
|
@bbarenblat any comment? We can make that check more specific to avoid what I'm guessing is some Linux or OpenSSL-variant related issue you have with it. |
|
Hey, folks, sorry for the delay. I’m pretty sure I removed that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some non-Linux systems, most notably FreeBSD and the other *BSDs, have OpenSSL as part of the base OS. FreeBSD, at least, does not have a pkg-config
.pcfile, because it's not actually a package. (All the *BSDs also have various OpenSSL versions and its forks available in packages as well. But using them can cause various kinds of pain dealing with multiple versions, and it's better to avoid them if they're not needed.)There was a check using
AX_CHECK_LIBRARY()that got lost in commit bacc024. This brings it back, and also removes extended GNU Make syntax that I accidentally put insrc/include/Makefile.acthat OpenBSDmakerefused to put up with.