Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes [CHORE] 767 action sheet design changes #767 #891

Merged
merged 3 commits into from
Mar 30, 2023
Merged

Changes [CHORE] 767 action sheet design changes #767 #891

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0727fd
Changes [CHORE] 767 action sheet design changes #767
adhiyan-tangoe Oct 11, 2022
686514e
Changes [CHORE] 767 action sheet design changes #891
adhiyan-tangoe Oct 12, 2022
4af91fe
Changes [CHORE] 767 action sheet design changes #891
adhiyan-tangoe Oct 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions projects/go-lib/src/lib/components/go-action-sheet/go-action-sheet.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@ $as-before-box-diag-width: 21.21px;
position: relative;

&__scroll-container {
max-height: 375px;
overflow: auto;
overflow: hidden;
}

&__content {
border-radius: $global-radius;
overflow: hidden;
max-height: 375px;
overflow: auto;
}

&__content-container {
Expand Down
8 changes: 2 additions & 6 deletions projects/go-lib/src/lib/components/go-action-sheet/go-panel/go-panel.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,8 @@ $theme-light-transparentized: rgba($theme-light-color, .5);
color: $ui-color-negative;
}

.go-panel {
&__title {
& &-text {
color: $ui-color-negative;
}
}
.go-panel__title-text {
swimtech20 marked this conversation as resolved.
Show resolved Hide resolved
color: $ui-color-negative;
}
}

Expand Down
1 change: 1 addition & 0 deletions projects/go-lib/src/lib/components/go-side-nav/go-side-nav/go-side-nav.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
<p class="go-side-nav__app-drawer--launch">{{ appDrawerHeader }}</p>
</go-panel>
<go-panel
class="go-side-nav__app-drawer--items"
*ngFor="let appDrawerItem of (navAppDrawer?.appDrawerConfig || [])"
[icon]="appDrawerItem.icon"
[panelContent]="appDrawerItem.displayName"
Expand Down
6 changes: 6 additions & 0 deletions projects/go-lib/src/lib/components/go-side-nav/go-side-nav/go-side-nav.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,5 +103,11 @@
background: $theme-light-bg;
}
}

&--items {
span.go-panel__title-text {
font-family: $secondary-font-stack !important;
}
adhiyan-tangoe marked this conversation as resolved.
Show resolved Hide resolved
}
}
}
2 changes: 2 additions & 0 deletions projects/go-style-guide/src/app/app.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,12 @@
</ng-container>
<ng-container go-action-sheet-content>
<go-panel
class="go-action-sheet-items"
panelContent="GitHub"
externalLink="https://github.com/mobi/goponents">
</go-panel>
<go-panel
class="go-action-sheet-items"
panelContent="NPM"
externalLink="https://www.npmjs.com/package/@tangoe/goponents">
</go-panel>
Expand Down
6 changes: 6 additions & 0 deletions projects/go-style-guide/src/app/app.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,3 +104,9 @@ code {
border-radius: $global-radius;
padding: $column-gutter;
}

.go-action-sheet-items {
span.go-panel__title-text {
font-family: $secondary-font-stack !important;
}
adhiyan-tangoe marked this conversation as resolved.
Show resolved Hide resolved
}