Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes [CHORE] 868 max height for toast #890

Merged
merged 3 commits into from
Mar 30, 2023
Merged

Changes [CHORE] 868 max height for toast #890

merged 3 commits into from
Mar 30, 2023

Conversation

adhiyan-tangoe
Copy link
Contributor

Max height for the toast notification will not have an overflow unless specified.

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added
  • Docs have been added or updated

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Style Update (CSS)
  • Other... Please describe:

What is the current behavior?

Resolves #868

What is the new behavior?

  1. Toast notification will have the style as fit content by default.
  2. To enable the scrollability behaviour enableMaxHeight should be set to true

Does this PR introduce a breaking change?

  • Yes
  • No

@adhiyan-tangoe
Changes [CHORE] 868 max height for toast
6fadeaa 
Max height for the toast notification will not have an overflow unless specified.
@adhiyan-tangoe adhiyan-tangoe self-assigned this Oct 11, 2022
@adhiyan-tangoe adhiyan-tangoe added chore General chore or maintenance task UX Review Waiting on review from UX labels Oct 11, 2022
swimtech20
swimtech20 reviewed Oct 11, 2022
View reviewed changes
Copy link
Collaborator

@swimtech20 swimtech20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a minor syntax fix.

projects/go-lib/src/lib/components/go-toast/go-toast.component.html Outdated Show resolved Hide resolved
@adhiyan-tangoe
Changes [CHORE] 868 max height for toast #890
05c0fb6 
1. Code review suggested changes.
2. Change in the code's header part in the documentation.
@adhiyan-tangoe
Changes [CHORE] 868 max height for toast #890
5505e72 
Code review suggested changes.
swimtech20
swimtech20 approved these changes Oct 13, 2022
View reviewed changes
Copy link
Collaborator

@swimtech20 swimtech20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@stolve
Copy link

stolve commented Jan 27, 2023

@kpmurphh and myself have no way to provide approval/feedback for this issue. We do not have an instance of goponents on our systems in order to look at the visual fix and we are not in a position to give feedback on coding approaches. Please attach a screenshot of the update or block time on one of our calendars for a review session.

@RonMichaud RonMichaud merged commit 0a815e8 into dev Mar 30, 2023
@RonMichaud RonMichaud deleted the GOP-868-CHORE-max_height_for_toast branch March 30, 2023 19:01
swimtech20 added a commit that referenced this pull request Jun 9, 2023
@swimtech20 @sudheepdivakargithub
@adhiyan-tangoe @Saravanan-Tangoe @Pooja-kj @Vijeta7 @RonMichaud @vishal-tangoe
v1.16.0 (#916)
669fcf9 
* Update go-button.component.scss

Changes for split button option text not to wrap and grow towards left.

* GOP-877-BUG-minimum_height_for_textarea

Fixed GOP-876 uniform card margins, GOP-877 set minimum_height_for_textarea and GOP-847 file uploading component bug fix.

* Changes_bugfix_chore_task

* alignment corrected for icon button

css changes for button padding

* codeclimate issue fix

* Codeclimate fix

* remove extra padding

* Initial components and module interaction

* Accordion_style changes

Accordion styles
Default
Slim
Dark

* Changed dark theme

* Changes [CHORE] 868 max height for toast

Max height for the toast notification will not have an overflow unless specified.

* Changes [CHORE] 767 action sheet design changes #767

1. Handled appearance of scrollbar on accordion's expansion by adjusting the height.
2. Font style changes for the shell area.
3. Fixed the colour issue for the danger action sheet.

* Update _forms.scss

* Changes [CHORE] 767 action sheet design changes #891

Code review suggestion changes

* Determinate and indeterminate progress bar

* style update

* Changes [CHORE] 868 max height for toast #890

1. Code review suggested changes.
2. Change in the code's header part in the documentation.

* UT

* safari styling fix

* Fixing code climate issues

* Changes [CHORE] 868 max height for toast #890

Code review suggested changes.

* Changes [CHORE] 767 action sheet design changes #891

Code review suggestion changes

* comment line message

* clear code climate issues

* code climate fix

* dark theme color changes done

* issue fixed

* removed white spaces

* BUGFIX_TIME_PICKER_ALIGNMENT-CHORE_BACKGROUND_COLOR_CHANGE

* ALIGNMENT AND NAMING CHANGES

* Fix for duplicate modal and offcanvas content

* ALIGNMENT_CHANGES

* removing whitespace

* Re-run Checks

* Re-run Checks

* Increasing test coverage

* Update github src

* GOP-807 empty checkin to trigger build

* Fix select all filtered list (#914)

* bug fixes for select all filtered list

* single item, add remove handled

* handling controls initial value incase of typeahead provided

* changes in handling controls initial value

* small condition fix

* test cases updated and condition change in init control value

* formatting changes

* formatting changes

* edge case handled while removing selected item

* formatting changes

* adding count to select all

* adding count to select all

* linting errors fixed

* typo fixed

* refactored code for better understanding

* refactoring

* lint fix

* indentation changes, private methods and variables grouped, minor ux changes

* renaming methods

* karma config thresold changes

---------

Co-authored-by: Vishal Shah <[email protected]>

* v1.16.0 (#915)

* Incrementing minor version

Changes were made to upgrade "select all filter list"

* Fixing patch version to be 0

Forgot to do this before...

---------

Co-authored-by: sudheepdivakargithub <[email protected]>
Co-authored-by: adhiyan-tangoe <[email protected]>
Co-authored-by: Saravanan Muralidharan <[email protected]>
Co-authored-by: Pooja-kj <[email protected]>
Co-authored-by: Vijeta7 <[email protected]>
Co-authored-by: [email protected] <[email protected]>
Co-authored-by: RonMichaud <[email protected]>
Co-authored-by: Vishal Shah <[email protected]>
swimtech20 added a commit that referenced this pull request Jan 5, 2024
@swimtech20 @sudheepdivakargithub
@adhiyan-tangoe @Saravanan-Tangoe @Pooja-kj @Vijeta7 @RonMichaud @vishal-tangoe @sinchananj12 @ankit-tangoe
Goponents release v1.16.1 (#933)
121e121 
* Update go-button.component.scss

Changes for split button option text not to wrap and grow towards left.

* GOP-877-BUG-minimum_height_for_textarea

Fixed GOP-876 uniform card margins, GOP-877 set minimum_height_for_textarea and GOP-847 file uploading component bug fix.

* Changes_bugfix_chore_task

* alignment corrected for icon button

css changes for button padding

* codeclimate issue fix

* Codeclimate fix

* remove extra padding

* Initial components and module interaction

* Accordion_style changes

Accordion styles
Default
Slim
Dark

* Changed dark theme

* Changes [CHORE] 868 max height for toast

Max height for the toast notification will not have an overflow unless specified.

* Changes [CHORE] 767 action sheet design changes #767

1. Handled appearance of scrollbar on accordion's expansion by adjusting the height.
2. Font style changes for the shell area.
3. Fixed the colour issue for the danger action sheet.

* Update _forms.scss

* Changes [CHORE] 767 action sheet design changes #891

Code review suggestion changes

* Determinate and indeterminate progress bar

* style update

* Changes [CHORE] 868 max height for toast #890

1. Code review suggested changes.
2. Change in the code's header part in the documentation.

* UT

* safari styling fix

* Fixing code climate issues

* Changes [CHORE] 868 max height for toast #890

Code review suggested changes.

* Changes [CHORE] 767 action sheet design changes #891

Code review suggestion changes

* comment line message

* clear code climate issues

* code climate fix

* dark theme color changes done

* issue fixed

* removed white spaces

* BUGFIX_TIME_PICKER_ALIGNMENT-CHORE_BACKGROUND_COLOR_CHANGE

* ALIGNMENT AND NAMING CHANGES

* Fix for duplicate modal and offcanvas content

* ALIGNMENT_CHANGES

* removing whitespace

* Re-run Checks

* Re-run Checks

* Increasing test coverage

* Update github src

* GOP-807 empty checkin to trigger build

* Fix select all filtered list (#914)

* bug fixes for select all filtered list

* single item, add remove handled

* handling controls initial value incase of typeahead provided

* changes in handling controls initial value

* small condition fix

* test cases updated and condition change in init control value

* formatting changes

* formatting changes

* edge case handled while removing selected item

* formatting changes

* adding count to select all

* adding count to select all

* linting errors fixed

* typo fixed

* refactored code for better understanding

* refactoring

* lint fix

* indentation changes, private methods and variables grouped, minor ux changes

* renaming methods

* karma config thresold changes

---------

Co-authored-by: Vishal Shah <[email protected]>

* v1.16.0 (#915)

* Incrementing minor version

Changes were made to upgrade "select all filter list"

* Fixing patch version to be 0

Forgot to do this before...

* #918 enhancement of go-date-picker

* #918 - enhance go-date-picker

* Added inout property to control the visibility of go-form-error.
Implemented in all controls with go-form-error.

* updated the documentation.

* Rearranged the property

* Used single quote instead of double quotes.

* Added few more tests

* #918 -  Added test cases

* Added app-drawer stylings

* Fixed code climate lint errors.

* Fixed code climate lint errors.

* Fixed code climate lint errors.

* Fixed code climate lint errors.

* Update CSS for Drodown and add test cases

* add few test cases based on background color

* Add some more test cases for disable color

* Resolve build issue and update test cases

* Resolve code coverage issue and add few more test cases

* Update test cases for enable and disable color for dropdown

* Updating version number to reflect recent changes

---------

Co-authored-by: sudheepdivakargithub <[email protected]>
Co-authored-by: adhiyan-tangoe <[email protected]>
Co-authored-by: Saravanan Muralidharan <[email protected]>
Co-authored-by: Pooja-kj <[email protected]>
Co-authored-by: Vijeta7 <[email protected]>
Co-authored-by: [email protected] <[email protected]>
Co-authored-by: RonMichaud <[email protected]>
Co-authored-by: Vishal Shah <[email protected]>
Co-authored-by: Sinchana <[email protected]>
Co-authored-by: CORP\Sudheep.Divakar <[email protected]>
Co-authored-by: Amit Patra <[email protected]>
Co-authored-by: ankit-tangoe <[email protected]>
swimtech20 added a commit that referenced this pull request Mar 19, 2024
@swimtech20 @sudheepdivakargithub
@adhiyan-tangoe @Saravanan-Tangoe @Pooja-kj @Vijeta7 @RonMichaud @vishal-tangoe @sinchananj12 @ankit-tangoe @preetigairi
Goponent Release 1.17.0 - Increasing minor version (in case of regres…
2ce0e2b 
…sion and easier history tracking) (#940)

* Update go-button.component.scss

Changes for split button option text not to wrap and grow towards left.

* GOP-877-BUG-minimum_height_for_textarea

Fixed GOP-876 uniform card margins, GOP-877 set minimum_height_for_textarea and GOP-847 file uploading component bug fix.

* Changes_bugfix_chore_task

* alignment corrected for icon button

css changes for button padding

* codeclimate issue fix

* Codeclimate fix

* remove extra padding

* Initial components and module interaction

* Accordion_style changes

Accordion styles
Default
Slim
Dark

* Changed dark theme

* Changes [CHORE] 868 max height for toast

Max height for the toast notification will not have an overflow unless specified.

* Changes [CHORE] 767 action sheet design changes #767

1. Handled appearance of scrollbar on accordion's expansion by adjusting the height.
2. Font style changes for the shell area.
3. Fixed the colour issue for the danger action sheet.

* Update _forms.scss

* Changes [CHORE] 767 action sheet design changes #891

Code review suggestion changes

* Determinate and indeterminate progress bar

* style update

* Changes [CHORE] 868 max height for toast #890

1. Code review suggested changes.
2. Change in the code's header part in the documentation.

* UT

* safari styling fix

* Fixing code climate issues

* Changes [CHORE] 868 max height for toast #890

Code review suggested changes.

* Changes [CHORE] 767 action sheet design changes #891

Code review suggestion changes

* comment line message

* clear code climate issues

* code climate fix

* dark theme color changes done

* issue fixed

* removed white spaces

* BUGFIX_TIME_PICKER_ALIGNMENT-CHORE_BACKGROUND_COLOR_CHANGE

* ALIGNMENT AND NAMING CHANGES

* Fix for duplicate modal and offcanvas content

* ALIGNMENT_CHANGES

* removing whitespace

* Re-run Checks

* Re-run Checks

* Increasing test coverage

* Update github src

* GOP-807 empty checkin to trigger build

* Fix select all filtered list (#914)

* bug fixes for select all filtered list

* single item, add remove handled

* handling controls initial value incase of typeahead provided

* changes in handling controls initial value

* small condition fix

* test cases updated and condition change in init control value

* formatting changes

* formatting changes

* edge case handled while removing selected item

* formatting changes

* adding count to select all

* adding count to select all

* linting errors fixed

* typo fixed

* refactored code for better understanding

* refactoring

* lint fix

* indentation changes, private methods and variables grouped, minor ux changes

* renaming methods

* karma config thresold changes

---------

Co-authored-by: Vishal Shah <[email protected]>

* v1.16.0 (#915)

* Incrementing minor version

Changes were made to upgrade "select all filter list"

* Fixing patch version to be 0

Forgot to do this before...

* #918 enhancement of go-date-picker

* #918 - enhance go-date-picker

* Added inout property to control the visibility of go-form-error.
Implemented in all controls with go-form-error.

* updated the documentation.

* Rearranged the property

* Used single quote instead of double quotes.

* Added few more tests

* #918 -  Added test cases

* Added app-drawer stylings

* Fixed code climate lint errors.

* Fixed code climate lint errors.

* Fixed code climate lint errors.

* Fixed code climate lint errors.

* Update CSS for Drodown and add test cases

* add few test cases based on background color

* Add some more test cases for disable color

* Resolve build issue and update test cases

* Resolve code coverage issue and add few more test cases

* Update test cases for enable and disable color for dropdown

* Updating version number to reflect recent changes

* Selecting date as 29 Feb for any of the date fields is throwing error across the modules (#936)

* FEB_29th_selection

* #GOCLD 2298 test cases

* #GOCLD 2298 test cases

* #GOCLD 2298 test cases

* Update Goponent version (#937)

Includes Leap Day calculations fix.

* Update minor version for release (#939)

* Update to major version release

For easier history tracking/bug fixing. Noticed there were several file changes (1 commit) in main but not in dev... thoughts are this is related to the Activity Manager feature Persistent worked on in 2022-2023.

* Making this a minor version update and not major

Discussed with Jiawei

---------

Co-authored-by: sudheepdivakargithub <[email protected]>
Co-authored-by: adhiyan-tangoe <[email protected]>
Co-authored-by: Saravanan Muralidharan <[email protected]>
Co-authored-by: Pooja-kj <[email protected]>
Co-authored-by: Vijeta7 <[email protected]>
Co-authored-by: [email protected] <[email protected]>
Co-authored-by: RonMichaud <[email protected]>
Co-authored-by: Vishal Shah <[email protected]>
Co-authored-by: Sinchana <[email protected]>
Co-authored-by: CORP\Sudheep.Divakar <[email protected]>
Co-authored-by: Amit Patra <[email protected]>
Co-authored-by: ankit-tangoe <[email protected]>
Co-authored-by: preetigairi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swimtech20 swimtech20 swimtech20 approved these changes

@jiaweicai92 jiaweicai92 Awaiting requested review from jiaweicai92

@stolve stolve Awaiting requested review from stolve

@kpmurphh kpmurphh Awaiting requested review from kpmurphh

Assignees

@adhiyan-tangoe adhiyan-tangoe

Labels
chore General chore or maintenance task UX Review Waiting on review from UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Chore] Max-height of Toast Component
4 participants
@adhiyan-tangoe @stolve @swimtech20 @RonMichaud