Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Editor #799

Merged
merged 6 commits into from
Jun 17, 2021
Merged

[Feature] Editor #799

merged 6 commits into from
Jun 17, 2021

Conversation

grahamhency
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added
  • Docs have been added or updated

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Style Update (CSS)
  • Other... Please describe:

What is the current behavior?

We do not have a go-editor component and are targeting Angular v8.

What is the new behavior?

This PR does 3 main things:

Introduce a New go-editor Component

This component extends the TinyMCE Angular component that provides:

  • Custom skins for light/dark modes that are consistent with the design system
  • Provides ability for labels and hints that are consistent with the rest of our form components
  • Simplified editor with standard plugins/toolbar
  • Added config object to GoConfigService to support baseUrl and language configurations for TinyMCE on a global app scale

Upgrade app to Angular v9

This change is necessary to provide adequate support for the version of TinyMCE we must use to accomplish all features listed above. These were the major changes included in this upgrade:

  • Removed unnecessary static: false values on ViewChild, ViewChildren, ContentChild, or ContentChildren
  • Removed all references to unnecessary entryComponents either on build, docs, or implementations
  • Added exports for all missing classes in the public_api for the go-lib project

Remove Reference to WYSIWYG

  • Removes references to the WYSIWYG docs
  • Provides a redirect to the go-editor docs

Does this PR introduce a breaking change?

  • Yes
  • No

@grahamhency grahamhency merged commit 64f350e into dev Jun 17, 2021
@grahamhency grahamhency deleted the feature_editor branch June 17, 2021 20:24
@grahamhency grahamhency mentioned this pull request Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant