Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Table: Duplicate selectAllEvents fired #724

Merged
merged 1 commit into from
Dec 8, 2020
Merged

[Bug] Table: Duplicate selectAllEvents fired #724

merged 1 commit into from
Dec 8, 2020

Conversation

grahamhency
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added
  • Docs have been added or updated

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Style Update (CSS)
  • Other... Please describe:

What is the current behavior?

The selectAllEvent fires twice when the checkbox is checked.

What is the new behavior?

The selectAllEvent only fires when the value is different.

Does this PR introduce a breaking change?

  • Yes
  • No

@grahamhency grahamhency added the bug Something isn't working label Dec 8, 2020
StevenUlmer
StevenUlmer approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@StevenUlmer StevenUlmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@grahamhency grahamhency merged commit 6386331 into dev Dec 8, 2020
@grahamhency grahamhency deleted the bug_table_dup_select_all_events branch December 8, 2020 19:13
@grahamhency grahamhency mentioned this pull request Jan 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StevenUlmer StevenUlmer StevenUlmer approved these changes

Assignees

@StevenUlmer StevenUlmer

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grahamhency @StevenUlmer