-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add appendTo features of go-datepicker module #720
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good first pass, I think we can make some improvements and simplifications though. Please see my comments.
Also, I looked at the deploy preview for this to see the functionality and there is a bug. To reproduce:
- Go to the example in the docs and open the modal
- Open the datepicker
- Click the close icon for the modal
- The datepicker remains on the page
projects/go-lib/src/lib/components/go-datepicker/go-calendar.component.html
Outdated
Show resolved
Hide resolved
projects/go-lib/src/lib/components/go-datepicker/go-calendar.component.ts
Outdated
Show resolved
Hide resolved
projects/go-lib/src/lib/components/go-datepicker/go-calendar.component.ts
Outdated
Show resolved
Hide resolved
projects/go-lib/src/lib/components/go-datepicker/go-calendar.component.ts
Outdated
Show resolved
Hide resolved
projects/go-lib/src/lib/components/go-datepicker/go-calendar.component.ts
Outdated
Show resolved
Hide resolved
projects/go-lib/src/lib/components/go-datepicker/go-calendar.component.ts
Outdated
Show resolved
Hide resolved
projects/go-lib/src/lib/components/go-datepicker/go-datepicker.component.ts
Outdated
Show resolved
Hide resolved
...features/ui-kit/components/form-docs/components/datepicker-docs/datepicker-docs.component.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, had to do some research and some trial & error to figure out how to not use the setTimeout
and other things. I've made some more comments, let me know your thoughts.
projects/go-lib/src/lib/components/go-datepicker/go-calendar.component.ts
Outdated
Show resolved
Hide resolved
projects/go-lib/src/lib/components/go-datepicker/go-calendar.component.ts
Outdated
Show resolved
Hide resolved
projects/go-lib/src/lib/components/go-datepicker/go-calendar.component.ts
Outdated
Show resolved
Hide resolved
projects/go-lib/src/lib/components/go-datepicker/go-calendar.component.ts
Outdated
Show resolved
Hide resolved
projects/go-lib/src/lib/components/go-datepicker/go-calendar.component.ts
Outdated
Show resolved
Hide resolved
projects/go-lib/src/lib/components/go-datepicker/go-calendar.component.ts
Outdated
Show resolved
Hide resolved
projects/go-lib/src/lib/components/go-datepicker/go-calendar.component.ts
Show resolved
Hide resolved
projects/go-lib/src/lib/components/go-datepicker/go-calendar.component.ts
Outdated
Show resolved
Hide resolved
projects/go-lib/src/lib/components/go-datepicker/go-datepicker.component.html
Outdated
Show resolved
Hide resolved
projects/go-lib/src/lib/components/go-datepicker/go-calendar.component.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one more comment on types.
Additionally, I think we need to write some tests for these changes and also fix the broken tests.
projects/go-lib/src/lib/components/go-datepicker/go-datepicker.component.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is good, but there are broken tests and we need tests for the updated code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes you proposed for the tests is not a solution. Those tests should still be in place an pass successfully.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
After clicking on the calendar icon calendar body was hiding behind of modal body.
Resolves 717
What is the new behavior?
Now it's displayed on the modal body.
Does this PR introduce a breaking change?