Text Area Max Length

[StevenUlmer]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines
• Tests for the changes have been added
• Docs have been added or updated

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Style Update (CSS)
• Other... Please describe:

What is the current behavior?

Resolves #705

What is the new behavior?

There is the ability to pass in a maxlength on the text area

Does this PR introduce a breaking change?

• Yes
• No

[jaredami]

Just noticed a typo but looks good otherwise 👍

[grahamhency]

@StevenUlmer, what if we also add on the minlength attribute to this? Probably not going to be used very often, but we're doing it in this PR as well #699

[grahamhency]

Looks good, thanks!

[jaredami]

Couple of things in addition to my question about attribute vs property binding:

1. Should we add default values and add some logic to ensure that the minlength can't be set to greater than the maxlength, like what was done here?
2. Should we technically use brackets when setting the binding values since the inputs are of type number rather than string? Maybe not worth caring about...

[jaredami]

One question I have about this is whether we should be using attr. for these. In the Angular docs it says: "It is recommended that you set an element property with a property binding whenever possible."

Also here it says "Attributes initialize DOM properties and then they are done. Property values can change; attribute values can't." I'm wondering if that means that when you use attr. it makes the binding static (i.e. it won't update if the value is changed)?

These two things make me think maybe we should just property binding here, unless the text-areas don't have these properties.