Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add directive for use in adding ability to copy permalinks to doc examples #588

Merged
merged 6 commits into from
Jun 16, 2020

Conversation

jaredami
Copy link
Contributor

@jaredami jaredami commented Jun 15, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #558

What is the new behavior?

This PR adds a directive which, when added to go-copy element within a go-card-header, enables it to function as a copy-permalink feature for our style-guide.

Example usage:

  <go-card class="go-column go-column--100" id="default">
    <header go-card-header>
      <h2 class="go-heading-2 go-heading--inline">Default</h2>
      <go-copy cardId="default" goCopyDocLink></go-copy>
    </header>
    <div go-card-content>
      <!-- card contend here -->
    </div>
  </go-card>

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@jaredami jaredami added the feature New feature request label Jun 15, 2020
@jaredami jaredami requested a review from grahamhency June 15, 2020 19:16
})
class TestParentComponent {}

fdescribe('GoCopyDocLinkDirective', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spy an fdescribe

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

Copy link
Contributor

@grahamhency grahamhency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jaredami jaredami merged commit ab32b9b into dev Jun 16, 2020
@jaredami jaredami deleted the feature_ability_to_copy_doc_permalinks branch June 16, 2020 17:47
@grahamhency grahamhency mentioned this pull request Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants