-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] App drawer support within side navigation #469
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just have a couple of comments, but I think we can say this is a good first pass. We're missing tests on this and I think we can refine the styles a little bit, but I don't want to hold up the functionality of it and we can always polish it in the next release.
projects/go-lib/src/lib/components/go-side-nav/go-side-nav/go-side-nav.component.scss
Show resolved
Hide resolved
projects/go-lib/src/lib/components/go-side-nav/go-side-nav/go-side-nav.component.scss
Outdated
Show resolved
Hide resolved
cursor: pointer; | ||
margin-left: auto; | ||
|
||
::ng-deep .go-side-nav__app-drawer--icon { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't love this.. but 🤷♂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I didn't know a better way of handling this 😞
@grahamhency addressed your comments, PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #60
What is the new behavior?
This PR introduces an app-drawer referencing the design here: https://tangoe.invisionapp.com/share/JCT2JAKXTQ9#/screens/374819807_Cloud_-_Expanded
It's not a 1:1 match yet, but this PR provides all current expected functionality. Changes to design will be discussed with UX team.
Does this PR introduce a breaking change?
Other information
N/A