Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] App drawer support within side navigation #469

Merged
merged 10 commits into from
Feb 11, 2020
Merged

[Feature] App drawer support within side navigation #469

merged 10 commits into from
Feb 11, 2020

Conversation

patrick-lewandowski
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #60

What is the new behavior?

This PR introduces an app-drawer referencing the design here: https://tangoe.invisionapp.com/share/JCT2JAKXTQ9#/screens/374819807_Cloud_-_Expanded

It's not a 1:1 match yet, but this PR provides all current expected functionality. Changes to design will be discussed with UX team.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N/A

Sorry, something went wrong.

@patrick-lewandowski patrick-lewandowski added the feature New feature request label Feb 11, 2020
@patrick-lewandowski patrick-lewandowski self-assigned this Feb 11, 2020
Copy link
Contributor

@grahamhency grahamhency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just have a couple of comments, but I think we can say this is a good first pass. We're missing tests on this and I think we can refine the styles a little bit, but I don't want to hold up the functionality of it and we can always polish it in the next release.

cursor: pointer;
margin-left: auto;

::ng-deep .go-side-nav__app-drawer--icon {
Copy link
Contributor

@grahamhency grahamhency Feb 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't love this.. but 🤷‍♂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I didn't know a better way of handling this 😞

@patrick-lewandowski
Copy link
Contributor Author

@grahamhency addressed your comments, PTAL

Copy link
Contributor

@grahamhency grahamhency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@grahamhency grahamhency merged commit a24d7e1 into mobi:dev Feb 11, 2020
@patrick-lewandowski patrick-lewandowski deleted the app-drawer branch February 11, 2020 21:05
This was referenced Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants