Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HTML within toast message #266

Merged
merged 1 commit into from
Oct 11, 2019
Merged

Support HTML within toast message #266

merged 1 commit into from
Oct 11, 2019

Conversation

patrick-lewandowski
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe: Chore

What is the current behavior?

HTML passed into message of toast would render as string instead of HTML.

Issue Number: #239

What is the new behavior?

HTML passed into message of toast will render as HTML. Executable HTML is not supported!

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Closes: #239

@grahamhency grahamhency self-requested a review October 11, 2019 18:12
@grahamhency grahamhency added this to the v1.3.0 milestone Oct 11, 2019
Copy link
Contributor

@grahamhency grahamhency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patryk0605 nice work, thanks for adding the docs too!

@grahamhency grahamhency merged commit d1a9360 into mobi:v1.3.0 Oct 11, 2019
@patrick-lewandowski patrick-lewandowski deleted the toast-html branch October 17, 2019 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants