Merge pull request #622 from mobi/chore_sidenav_external_target

[Chore] Sidenav External Target
mobi · Jul 14, 2020 · 5b8fb36 · 5b8fb36
2 parents 7dd93cc + 0a23859
commit 5b8fb36
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/projects/go-lib/src/lib/components/go-side-nav/go-nav-item/go-nav-item.component.html b/projects/go-lib/src/lib/components/go-side-nav/go-nav-item/go-nav-item.component.html
@@ -15,8 +15,7 @@
   <a class="go-nav-item__link"
      *ngIf="navItem.isExternalLink"
      [href]="navItem.route"
-     [target]="navItem.externalLinkTarget ? navItem.externalLinkTarget : '_blank'"
-     rel="noreferrer">
+     [target]="navItem.externalLinkTarget ? navItem.externalLinkTarget : '_blank'">
     <ng-container *ngTemplateOutlet="navItemInner"></ng-container>
     <go-icon *ngIf="(!navItem.externalLinkTarget || navItem.externalLinkTarget === '_blank') && navService.navOpen"
              icon="launch"

diff --git a/projects/go-lib/src/lib/components/go-side-nav/nav-item.model.ts b/projects/go-lib/src/lib/components/go-side-nav/nav-item.model.ts
@@ -13,5 +13,5 @@ export interface NavItem {
    * new tab unless a different target is specified within `externalLinkTarget`.
    */
   isExternalLink?: boolean;
-  externalLinkTarget?: '_self' | '_blank' | '_parent' | '_top';
+  externalLinkTarget?: '_self' | '_blank' | '_parent' | '_top' | string;
 }
diff --git a/.../app/features/ui-kit/components/layout-docs/components/layout-nav/layout-nav.component.ts b/.../app/features/ui-kit/components/layout-docs/components/layout-nav/layout-nav.component.ts
@@ -27,7 +27,7 @@ export class LayoutNavComponent {
      * links will open in a new tab unless a different target is specified within externalLinkTarget.
      */
     isExternalLink?: boolean;
-    externalLinkTarget?: '_self' | '_blank' | '_parent' | '_top';
+    externalLinkTarget?: '_self' | '_blank' | '_parent' | '_top' | string;
   }
 
   export interface NavGroup {

diff --git a/projects/go-tester/src/app/components/layout/layout.component.ts b/projects/go-tester/src/app/components/layout/layout.component.ts
@@ -34,7 +34,8 @@ export class LayoutComponent implements OnInit {
       routeTitle: 'External Link (In a New Tab)',
       description: 'Test external link opening in new tab',
       route: 'https://www.google.com/',
-      isExternalLink: true
+      isExternalLink: true,
+      externalLinkTarget: 'Google'
     },
     {
       routeIcon: 'search',