Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

World simulation bug due to transform movement #47

Closed
wanwanyahoo opened this issue Apr 28, 2019 · 15 comments
Closed

World simulation bug due to transform movement #47

wanwanyahoo opened this issue Apr 28, 2019 · 15 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@wanwanyahoo
Copy link

how to make particle already emitted not follow emit transform?
I try simulation space to world but is wont't work after add ui particle script

@mob-sakai mob-sakai self-assigned this Apr 29, 2019
@mob-sakai mob-sakai added the question Further information is requested label Apr 29, 2019
@mob-sakai
Copy link
Owner

Hi @wanwanyahoo
Thank you for reporting. :)

I would like to know more information on this issue.
Can you submit a small reproducible project for this issue?

@ALPSquid
Copy link

ALPSquid commented May 1, 2019

Hi @mob-sakai
I've identified the same issue with world space particles and it's very simple to reproduce. The issue being that already emitted particles don't stay in their world position when the particle system transform is moved.

Steps

  1. Create a normal particle system (no UI Particle component) and set the simulation space to world.
  2. Move the particle system transform.
    • Notice how already emitted particles stay in the current position regardless of where the transform is moved. This is the expected behaviour.
  3. Add a UI Particle component.
  4. Move the particle system transform.
    • Notice how already emitted particles move relative to where the transform is moved. This is not the expected behaviour.

Commit 68da045 seems to have broken this behaviour as removing the added positioning code (Ln 305 - 325) makes world space particles behave as expected.

@mob-sakai
Copy link
Owner

@ALPSquid @wanwanyahoo
Thanks.
Please tell me more informations about this issue.

  • Unity version
  • ParticleEffectForUGUI version
  • Platforms (Editor[Windows/Mac]/Standalone[Windows/Mac]/iOS/Android)
  • etc...

@wanwanyahoo
Copy link
Author

wanwanyahoo commented May 1, 2019 via email

@ALPSquid
Copy link

ALPSquid commented May 1, 2019

Unity version: 2018.3.8f1
ParticleEffectForUGUI version: 2.2.1
Platform: Editor - Windows 10

@mob-sakai
Copy link
Owner

mob-sakai commented May 2, 2019

Unity version: 2018.3.10f1
ParticleEffectForUGUI version: 2.2.1
Platform: Editor - Mac

Edit: This issue is reproduced when scaling mode is set to Local.

Hmm...
In my environment, it seems to work well.
May-02-2019 10-47-13

image

test.unitypackage.zip

@wanwanyahoo @ALPSquid
Can you submit a small reproducible project for this issue?

@mob-sakai
Copy link
Owner

mob-sakai commented May 2, 2019

Oh, this issue is reproduced in my environment when scaling mode is set to Local.
It works well when scaling mode is set to Hierarchy.

@wanwanyahoo
Copy link
Author

wanwanyahoo commented May 2, 2019 via email

@mob-sakai
Copy link
Owner

@wanwanyahoo @ALPSquid
What's RenderMode do you use?

  • Screen Space - Overlay
  • Screen Space - Camera
  • World Space - Camera

@ALPSquid
Copy link

ALPSquid commented May 7, 2019

@mob-sakai I'm using Screen Space - Camera

@wanwanyahoo
Copy link
Author

wanwanyahoo commented May 7, 2019 via email

@mob-sakai
Copy link
Owner

I have a good news!
I found a more accurate calculation model and it will solve this issue!

Before
May-07-2019 23-59-50

After
May-07-2019 23-54-12

@mob-sakai
Copy link
Owner

@wanwanyahoo @ALPSquid
Import this package and test it.
If there is no problem, it will be released as v2.3.0. :)
v2.3.0-pre.unitypackage.zip

@wanwanyahoo
Copy link
Author

wanwanyahoo commented May 8, 2019 via email

@ALPSquid
Copy link

ALPSquid commented May 8, 2019

@wanwanyahoo @ALPSquid
Import this package and test it.
If there is no problem, it will be released as v2.3.0. :)
v2.3.0-pre.unitypackage.zip

@mob-sakai
That seems to be working great, cheers! I'm not able to test any other use cases at the moment, just the Local Scale, World Sim in Camera Screen Space, but that's working as expected.

@mob-sakai mob-sakai changed the title how to make particle already emitted not follow emit transform? World simulation bug May 10, 2019
@mob-sakai mob-sakai added bug Something isn't working and removed question Further information is requested labels May 10, 2019
@mob-sakai mob-sakai added this to the 2.3.0 milestone May 10, 2019
@mob-sakai mob-sakai changed the title World simulation bug World simulation bug due to transform movement May 12, 2019
mob-sakai added a commit that referenced this issue May 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants