Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spawning Particle Prefabs. Rendering stops on older ones after 4+. #117

Closed
npicouet opened this issue Nov 18, 2020 · 4 comments
Closed

Spawning Particle Prefabs. Rendering stops on older ones after 4+. #117

npicouet opened this issue Nov 18, 2020 · 4 comments
Assignees
@mob-sakai
Labels
bug Something isn't working released on @main

Comments

@npicouet
Copy link

npicouet commented Nov 18, 2020 •
edited
Loading

Describe the bug
Spawning multiple particle prefabs. Each have their own UI Particle renderer.
Each system destroys itself when complete.
Each system is a texture sheet animation using a multiple mode packed image.
After spawning 4-5+, the rendering on older ones starts failing.

To Reproduce
Steps to reproduce the behavior:

  1. Spawn particle prefabs from code.
  2. Each prefab should have a particlesystem and uiparticle, and callback on done to destroy, as well as set up to be a texture sheet animation with multiple mode packed image.
  3. After spawning multiple, rendering fails randomly.

Expected behavior
Rendering should be self contained on each prefab and never fail when others are destroying.

Environment (please complete the following information):
Unity 2019.4.12f1, Mac OSX, Editor
IL2CPP, .Net 4, Standard Pipeline
Latest release (3.2.0)
@npicouet npicouet added the bug Something isn't working label Nov 18, 2020
@mob-sakai
Copy link
Owner

@npicouet
Could you please attach a minimal project (included Assets, Packages and ProjectSettings directories) that reproduces the issue?

@npicouet
Copy link
Author

Here is a minimal project, I was able to recreate it in here.
Download Link

mob-sakai added a commit that referenced this issue Nov 20, 2020
@mob-sakai
fix: the particles may disappear unintentionally
2ec81da 
Close #117
github-actions bot pushed a commit that referenced this issue Nov 20, 2020
@semantic-release-bot
chore(release): 3.3.0 [skip ci]
429ff2d 
# [3.3.0](3.2.0...3.3.0) (2020-11-20)

### Bug Fixes

* the particles may disappear unintentionally ([2ec81da](2ec81da)), closes [#117](#117)

### Features

* ignore rendering of particle systems that do not have a SharedMaterial and TrailMaterial ([08c4aba](08c4aba)), closes [#118](#118)
* show/hide materials in inspector ([4b4aebf](4b4aebf))
* shrink rendering by material ([46a7ddd](46a7ddd)), closes [#113](#113)
@github-actions
Copy link

🎉 This issue has been resolved in version 3.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@mob-sakai
Copy link
Owner

Fixed in v3.3.0

LionelPerrault added a commit to LionelPerrault/Unity-Particle that referenced this issue Jul 25, 2023
@LionelPerrault
chore(release): 3.3.0 [skip ci]
4ddbe71 
# [3.3.0](mob-sakai/ParticleEffectForUGUI@3.2.0...3.3.0) (2020-11-20)

### Bug Fixes

* the particles may disappear unintentionally ([2ec81da](mob-sakai/ParticleEffectForUGUI@2ec81da)), closes [#117](mob-sakai/ParticleEffectForUGUI#117)

### Features

* ignore rendering of particle systems that do not have a SharedMaterial and TrailMaterial ([08c4aba](mob-sakai/ParticleEffectForUGUI@08c4aba)), closes [#118](mob-sakai/ParticleEffectForUGUI#118)
* show/hide materials in inspector ([4b4aebf](mob-sakai/ParticleEffectForUGUI@4b4aebf))
* shrink rendering by material ([46a7ddd](mob-sakai/ParticleEffectForUGUI@46a7ddd)), closes [#113](mob-sakai/ParticleEffectForUGUI#113)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mob-sakai mob-sakai

Labels
bug Something isn't working released on @main
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@npicouet @mob-sakai