Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with other components that implement <IMaterialModifier> #115

Closed
ltccss opened this issue Nov 13, 2020 · 2 comments
Closed

Compatibility with other components that implement <IMaterialModifier> #115

ltccss opened this issue Nov 13, 2020 · 2 comments
Assignees
@mob-sakai
Labels
enhancement New feature or request released

Comments

@ltccss
Copy link

ltccss commented Nov 13, 2020

ParticleEffectForUGUI/Scripts/UIParticle.cs

Line 220 in 06d8fae

protected override void UpdateMaterial()

Currently UIParticle overrides the method UpdateMaterial, but dose not handle the property materialForRendering as the super class does, which leads to that those who implement the interface IMaterialModifier don't work
@mob-sakai mob-sakai self-assigned this Nov 13, 2020
@mob-sakai mob-sakai added the enhancement New feature or request label Nov 13, 2020
@mob-sakai
Copy link
Owner

@ltccss
Thank you for the feature request!

github-actions bot pushed a commit that referenced this issue Nov 15, 2020
@semantic-release-bot
chore(release): 3.2.0 [skip ci]
6884c62 
# [3.2.0](3.1.1...3.2.0) (2020-11-15)

### Features

* compatibility with other IMaterialModifier ([08273cb](08273cb)), closes [#115](#115)
@github-actions
Copy link

🎉 This issue has been resolved in version 3.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

LionelPerrault added a commit to LionelPerrault/Unity-Particle that referenced this issue Jul 25, 2023
@LionelPerrault
chore(release): 3.2.0 [skip ci]
1636dbc 
# [3.2.0](mob-sakai/ParticleEffectForUGUI@3.1.1...3.2.0) (2020-11-15)

### Features

* compatibility with other IMaterialModifier ([08273cb](mob-sakai/ParticleEffectForUGUI@08273cb)), closes [#115](mob-sakai/ParticleEffectForUGUI#115)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mob-sakai mob-sakai

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mob-sakai @ltccss