Fix duplicate files and wrong identation #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ArithmeticOperation.java - ArithmeticOperationTest.java Ref moar82#1
cristian-aldea
suggested changes
Apr 1, 2021
Comment on lines
+12
to
+14
| Integer actual = operations.addOrSub(2, 6); | ||
| Integer expected = 8; | ||
| assertEquals(expected, actual); |
There was a problem hiding this comment.
💡 Same for the one below
Suggested change
| Integer actual = operations.addOrSub(2, 6); | |
| Integer expected = 8; | |
| assertEquals(expected, actual); | |
| assertEquals(8, operations.addOrSub(2, 6)); |
| @@ -2,8 +2,7 @@ | |||
|
|
|||
| public class ArithmeticOperation { | |||
|
|
|||
| public Integer addOrSub(Integer a, Integer b) | |||
| { | |||
| public Integer addOrSub(Integer a, Integer b) { | |||
| if (a > b) { | |||
There was a problem hiding this comment.
Might as well shorten this code in the interest of quality :^)
Instead of
if (a > b) {
return a - b;
} else {
return a + b;
}
Do
return a > b ? a - b : a + b;
There was a problem hiding this comment.
Might as well shorten this code in the interest of quality :^)
Instead of
if (a > b) { return a - b; } else { return a + b; }Do
return a > b ? a - b : a + b;
Not agree with this. The use of the ternary operation affects code readability is not a recommended practice.
There was a problem hiding this comment.
Ah my bad you're right, nevermind my comment then
There was a problem hiding this comment.
I agree. Unless you are a 10x developer, those changes would affect code readability.
cristian-aldea
approved these changes
Apr 9, 2021
gfdb
added a commit
to gfdb/ArithmeticOperation
that referenced
this pull request
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #1.
Hope this helps with the code quality!