Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate files and wrong identation #1

Open
cristian-aldea opened this issue Mar 31, 2021 · 1 comment · May be fixed by #2
Open

Fix duplicate files and wrong identation #1

cristian-aldea opened this issue Mar 31, 2021 · 1 comment · May be fixed by #2

Comments

@cristian-aldea
Copy link

cristian-aldea commented Mar 31, 2021 •
edited
Loading

In this repo, there's a few instances of duplicate code and wrong identation. If they're fixed, it would improve the code quality :)

The two files here are basically duplicates
image

The indentation in this file is off
image
@moar82
Copy link
Owner

moar82 commented Mar 31, 2021

Hi Cristian, that is correct.
Just for the record, I'm not taking credit for this example as is not of my authorship. However, I welcome your comments, and I will fix it after the semester ends and no one is working with the code.
If you wish to help you can also submit a pull request with the corresponding fixes. :) Do not hesitate!

bit172 added a commit to bit172/ArithmeticOperation that referenced this issue Mar 31, 2021
@bit172
chore: Deleted duplicate files
e342b86 
Ref moar82#1
bit172 added a commit to bit172/ArithmeticOperation that referenced this issue Mar 31, 2021
@bit172
style: format code
9d74de8 
- ArithmeticOperation.java
- ArithmeticOperationTest.java

Ref moar82#1
bit172 added a commit to bit172/ArithmeticOperation that referenced this issue Mar 31, 2021
@bit172
chore: deleted duplicate files
ea9a49a 
Ref moar82#1
bit172 added a commit to bit172/ArithmeticOperation that referenced this issue Mar 31, 2021
@bit172
style: format code
078d25b 
- ArithmeticOperation.java
- ArithmeticOperationTest.java

Ref moar82#1
@bit172 bit172 linked a pull request Apr 1, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix duplicate files and wrong identation bit172/ArithmeticOperation
2 participants
@moar82 @cristian-aldea