Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a HotSpotEventListener to the HotSpot is not working #141

Closed
risayew opened this issue Sep 16, 2014 · 4 comments
Closed

Adding a HotSpotEventListener to the HotSpot is not working #141

risayew opened this issue Sep 16, 2014 · 4 comments

Comments

@risayew
Copy link

risayew commented Sep 16, 2014

Hi there.
Thank you very much for your library.
The events listener, assigned directly to the hot spot can not be called.
The problem is in the HotSpotManager:
public void processHit( Point point ){
...
// fast-fail if no listeners
if(listeners.isEmpty()){
return;
}
...
}
If there is no listener, added to the tile view, then a listener added directly to the hot spot instance will be never called

@moagrius
Copy link
Owner

good catch, thank you. if you want to fork and PR to remove that test, I'll merge, otherwise I'll make the patch myself when I get some time.

@risayew
Copy link
Author

risayew commented Oct 7, 2014

Could you, please, make this small patch by yourself?

@moagrius
Copy link
Owner

moagrius commented Oct 7, 2014

sure

moagrius added a commit that referenced this issue Nov 30, 2014
moagrius added a commit that referenced this issue Nov 30, 2014
removed isEmpty fast-fail per #141
@moagrius
Copy link
Owner

This is fixed in the latest commit. Note that I have not released a new .jar, you'll need to grab the source, nor have I updated the docs (just moved to AS from Eclipse, which had those tasks pretty well baked-in, still getting used to AS).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants