Corrected Get-WindowsOptionalFeature logic for client OS.

mnothh · Jun 28, 2019 · 1cf4da1 · 1cf4da1
1 parent 1fb8d15
commit 1cf4da1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/Misc/xBitlockerCommon.psm1 b/Misc/xBitlockerCommon.psm1
@@ -790,8 +790,8 @@ function Assert-HasPrereqsForBitlocker
 
     if ((Get-OSEdition) -like 'Client')
     {
-        $blFeature = Get-WindowsOptionalFeature BitLocker
-        if ($blFeature.InstallState -ne 'Installed')
+        $blFeature = Get-WindowsOptionalFeature -Online -FeatureName 'BitLocker'
+        if ($blFeature.State -ne 'Enabled')
         {
             $hasAllPreReqs = $false
             Write-Error 'The Bitlocker feature needs to be installed before the xBitlocker module can be used'

diff --git a/Tests/Unit/xBitlockerCommon.tests.ps1 b/Tests/Unit/xBitlockerCommon.tests.ps1
@@ -309,14 +309,16 @@ try
                 Mock -CommandName Get-WindowsOptionalFeature -MockWith {
                     param
                     (
+                        [switch]
+                        $online = $false,
                         [string]
                         $FeatureName
                     )
 
                     return @{
                         DisplayName  = $FeatureName
                         Name         = $FeatureName
-                        InstallState = 'Installed'
+                        State = 'Enabled'
                     }
                 }