Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

Update to stable rustc and current byteorder. #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zbynekwinkler
Copy link

@zbynekwinkler zbynekwinkler commented Apr 15, 2016

Removes #![feature(slice_splits)].
Replaces byteorder::{Error,Result} with std::io::{Error,Result}.
Fixes all warnings (hopefully not breaking things).
Updates github link in readme.

Fixes #55.

Removes #![feature(slice_splits)].
Replaces byteorder::{Error,Result} with std::io::{Error,Result}.
Fixes all warnings (hopefully not breaking things).
Updates github link in readme.
@ShadowNinja
Copy link

Bump The package is broken without this.

Also, the docs should be updated, the serialize crate has apparently been replaced with rustc_serialize:

error: use of unstable library feature 'rustc_private': deprecated in favor of rustc-serialize on crates.io (see issue #27812)
extern crate serialize;
^~~~~~~~~~~~~~~~~~~~~~~

@kallisti5
Copy link

Any love for this? I'd like to play with msgpack in rust but the only implementation is broken. The package from cargo is broken. (1.11.0)

@bkfox
Copy link

bkfox commented Nov 20, 2016

up! I think a lot of people need this one.

@Enet4
Copy link

Enet4 commented Feb 17, 2017

Has the author shown any intent to maintain this project? The repository could seriously use an active maintainer, with the number of people interested in using and contributing to the crate.

@avongluck-r1soft
Copy link

I don't have the bandwidth to take on another project... however maybe a shared repo between a bunch of people to keep up with it? Original author seems in the wind.

@lbolla
Copy link

lbolla commented Sep 30, 2017

I am in favour of forking this repo, fixing it and uploading it to crates.io to replace the broken one.
Also, updating http://msgpack.org/ to point to the new fixed version.

@Enet4
Copy link

Enet4 commented Oct 2, 2017

While I understand it's not very "correct" to advertise other solutions, it seems best for us to use and contribute to the RMP project instead. This one is actively maintainted and provides Serde integration. The official msgpack.org website does seem to point to RMP on their website already.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants