-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC, MAINT: test theme CSS fixes #8961
Conversation
Link to doc build: https://25434-1301584-gh.circle-artifacts.com/0/dev/index.html |
something is going wrong with CircleCI here. It is definitely checking out the correct version of the theme:
But in the rendered site, it's using a version of the theme CSS file that does not exist in the checked-out version of the theme (the theme generates the CSS from SCSS sources, and incorporates a hash into the generated CSS filename, so it's really obvious when this has happened). Specifically, the docs should be using
(note the different hash). In the rendered artifact you can confirm with browser dev tools that the wrong CSS file is loaded. I think this might be related to our new-ish procedure of "restoring cache" to save build time? |
I've just triggered a circle re-run to see if it fixes itself. |
CircleCI is great because you can remotely debug it, in the upper right you can "Rebuild with SSH" |
didn't fix itself; re-running with SSH |
What I've determined so far:
(from the last "restoring cache" step right before the "get python running" step)
...and there are lines later about finding its dependencies are already present:
...but there is never a line saying "requirement already satisified: pyvista-sphinx-theme", nor is there a line saying "successfully installed pydata-sphinx-theme". So AFAICT the updated version is getting cloned but not installed (IDK why) and the only reason this doesn't crash the doc build is that an older version of the theme already exists (restored from cache). |
Didn't seem to work, pushed a workaround |
Docs/CSS look correct now. Failures are |
Thanks @drammock |
This updates our site CSS and javascript in response to some upstream theme bugfixes:
Once the second PR above is merged, we'll need to update the theme commit that we pin to in
requirements_doc.txt