Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update governance #12896

Merged
merged 12 commits into from
Dec 3, 2024
Merged

update governance #12896

merged 12 commits into from
Dec 3, 2024

Conversation

drammock
Copy link
Member

@drammock drammock commented Oct 11, 2024 •
edited
Loading

Update our public governance document.

TODOs:

  • now that new governance is adopted, set a deadline for current maintainer team members to volunteer for steering council. deadline is Nov 1 and was announced on Discord and maintainer email list
  • Once steering council membership finalized, update doc/overview/people.rst
  • the sections on "the project" and "institutional partners" were not included in the proposed restructuring. For now I've left them in place. If folks disagree with that course of action, I think we could summarize the "institutional partners" content at the start of the "institutional partners" list on doc/overview/people.rst instead.

britta-wstnr
britta-wstnr reviewed Oct 15, 2024
View reviewed changes
Copy link
Member

@britta-wstnr britta-wstnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Unified capitalization a bit more - hope I have caught all (most) things.

@sappelhoff
Copy link
Member

sappelhoff commented Oct 16, 2024 •
edited
Loading

the sections on "the project" and "institutional partners" were not included in the proposed restructuring. For now I've left them in place.

I agree with this. However note that I have not been employed by "Max Planck Institute für Bildungsforschung" since 2024-07-14. So I guess this triggered the "1 year grace period" for them until they are moved to "former partners". Shall I create an event for this on our mne steering council calendar?

EDIT: As institutional partners are typically tied to a steering council member, it would be good to put some processes in place that these steering council members keep track of adding / removing the institutional partners (and how, e.g., with calendar entries for removal).

@sappelhoff sappelhoff mentioned this pull request Oct 29, 2024
Open
@drammock drammock marked this pull request as ready for review December 3, 2024 15:29
@drammock drammock requested a review from dengemann as a code owner December 3, 2024 15:29
larsoner
larsoner approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking for merge-when-green, thanks in advance @drammock !

@larsoner larsoner enabled auto-merge (squash) December 3, 2024 16:07
@larsoner larsoner merged commit a1a05ae into mne-tools:main Dec 3, 2024
28 checks passed
@drammock drammock deleted the governance branch December 3, 2024 17:34
larsoner added a commit to larsoner/mne-python that referenced this pull request Dec 6, 2024
@larsoner
Merge remote-tracking branch 'upstream/main' into cola5
0adefdf 
* upstream/main: (736 commits)
  ENH: Add round-trip channel name saving (mne-tools#13003)
  update governance (mne-tools#12896)
  pin selenium and stop filtering its warning (mne-tools#13000)
  DOC: fix return value doc of inst.get_montage() (mne-tools#12995)
  remove some ._filenames uses in favor of .filenames (mne-tools#12996)
  use eegbci.standardize instead of custom code (mne-tools#12997)
  Bump autofix-ci/action from dd55f44df8f7cdb7a6bf74c78677eb8acd40cd0a to ff86a557419858bb967097bfc916833f5647fa8c in the actions group (mne-tools#12999)
  MAINT: Update code credit (mne-tools#12998)
  MAINT: Unpin VTK (mne-tools#12991)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#12988)
  Fix: update cnt.py to check missing annotation (mne-tools#12986)
  do not log about using set_montage AGAIN if it has never been used (mne-tools#12984)
  DOC: fix numpy docstr example Vectorizer() (mne-tools#12983)
  Changed epochs_clean_sub = model_plain.apply(epochs) to epochs_clean_sub = model_sub.apply(epochs), making use of the regression coefficients from model_sub. mne-tools#12977 (mne-tools#12978)
  DOC: add meegkit to related software suite (mne-tools#12976)
  DOC: specify tmax_raw param may be None, and what it means (mne-tools#12972)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#12975)
  DOC: fix note in legacy pick_channels func (mne-tools#12973)
  Use `uint16_codec` argument (mne-tools#12971)
  Bump codecov/codecov-action from 4 to 5 in the actions group (mne-tools#12970)
  ...
@sappelhoff sappelhoff mentioned this pull request Feb 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agramfort agramfort agramfort approved these changes

@larsoner larsoner larsoner approved these changes

@sappelhoff sappelhoff sappelhoff approved these changes

@britta-wstnr britta-wstnr britta-wstnr approved these changes

@dengemann dengemann Awaiting requested review from dengemann dengemann is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@drammock @sappelhoff @agramfort @larsoner @britta-wstnr