-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve drawing of annotations with matplotlib #11855
Merged
Merged
Changes from 17 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
6e1eacd
improve drawing of annotations with mpl
mscheltienne 96fdad2
improve instructions [ci skip]
mscheltienne 60773b6
Merge remote-tracking branch 'upstream/main' into annotations [ci skip]
mscheltienne 453f108
avoid for loop [ci skip]
mscheltienne d4cdb2d
add test for merging annotations in the Qt backend by dragging edges …
mscheltienne 60a9f86
fix test by using different values
mscheltienne 903a4f0
give 2 sample of freedom to handle the click between samples
mscheltienne f2aa3b2
give 10 samples of freedom to balance the imprecise _fake_click
mscheltienne 6aa9fdd
Merge branch 'main' into annotations
mscheltienne 3f6b63c
trigger cis
mscheltienne c2e0a7b
FIX: Use main mne-qt-browser
larsoner 688bb79
FIX: pip
larsoner 6d07ba3
Merge branch 'main' into annotations
larsoner a518dbd
FIX: xfail
larsoner 93f8601
FIX: More
larsoner bd7da64
Merge branch 'main' into annotations
larsoner 2319763
Merge branch 'main' into annotations
larsoner 491fdac
Update mne/viz/tests/test_raw.py [ci skip]
larsoner 2bf5775
Merge branch 'main' into annotations
larsoner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you have a better idea to get that test working, I'm listening. In mne-tools/mne-qt-browser#178, it failed the Ubuntu and Windows CIs (link) with
atol = 2 / raw.info["sfreq"]
. Locally, on an ubuntu-based distro it was passing..It looks to me like the
_fake_click
location is not very precise. I tried changing the onset/duration/click locations with values corresponding to an exact sample, without luck. For instance, I tried to click on the right edge of an annotation and it was working.. within +/- 15 samples of the actual edge location.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it's possible and I think it's okay to have a loose tolerance. As long as it's strict enough to catch if we broke things it should be fine. We can always improve the tolerance later