Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MRG: Allow retrieval of channel names via make_1020_channel_selections() #11632

Merged
merged 1 commit into from
Apr 17, 2023
Merged

MRG: Allow retrieval of channel names via make_1020_channel_selections() #11632

merged 1 commit into from
Apr 17, 2023

Conversation

hoechenberger
Copy link
Member

@hoechenberger hoechenberger commented Apr 16, 2023 •
edited
Loading

Previously, only indices would be returned. But users may commonly be interested in the channel names. This new parameter makes things easier while retaining backward compatibility.

Fixes #11597

@hoechenberger hoechenberger force-pushed the hoechenberger/issue11597 branch from 69bfa77 to 500a800 Compare April 16, 2023 15:39
@hoechenberger hoechenberger marked this pull request as ready for review April 16, 2023 15:40
@hoechenberger hoechenberger force-pushed the hoechenberger/issue11597 branch from 500a800 to d2a2915 Compare April 16, 2023 15:50
@hoechenberger hoechenberger changed the title Allow retrieval of channel names via make_1020_channel_selections() MRG: Allow retrieval of channel names via make_1020_channel_selections() Apr 16, 2023
hoechenberger
hoechenberger commented Apr 16, 2023
View reviewed changes
examples/preprocessing/contralateral_referencing.py
Comment on lines -34 to +35
ch_indices = mne.channels.make_1020_channel_selections(raw.info)

# convert indices to names
orig_names = np.array(raw.ch_names)
ch_names = {key: orig_names[idxs].tolist() for key, idxs in ch_indices.items()}
ch_names = mne.channels.make_1020_channel_selections(
raw.info, return_ch_names=True
)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we can see the simplification in user code thanks to this PR

@drammock drammock enabled auto-merge (squash) April 16, 2023 21:24
@hoechenberger

This comment was marked as resolved.

Sign in to view
auto-merge was automatically disabled April 17, 2023 08:40

Pull request was closed

@hoechenberger hoechenberger reopened this Apr 17, 2023
@hoechenberger hoechenberger enabled auto-merge (squash) April 17, 2023 08:40
@hoechenberger hoechenberger force-pushed the hoechenberger/issue11597 branch from dbefc56 to 69abd8b Compare April 17, 2023 09:08
@hoechenberger hoechenberger merged commit f88f22d into mne-tools:main Apr 17, 2023
@hoechenberger hoechenberger deleted the hoechenberger/issue11597 branch April 17, 2023 10:28
larsoner added a commit to cbrnr/mne-python that referenced this pull request Apr 21, 2023
@larsoner
Merge remote-tracking branch 'upstream/main' into precommit
1770b7b 
* upstream/main: (50 commits)
  BUG: Fix bug with paths (mne-tools#11639)
  MAINT: Report download time and size (mne-tools#11635)
  MRG: Allow retrieval of channel names via make_1020_channel_selections() (mne-tools#11632)
  Fix index name in to_data_frame()'s docstring (mne-tools#11457)
  MAINT: Use VTK prerelease wheels in pre jobs (mne-tools#11629)
  ENH: Allow gradient compensated data in maxwell_filter (mne-tools#10554)
  make test compatible with future pandas (mne-tools#11625)
  Display SVG figures correctly in Report (mne-tools#11623)
  API: Port ieeg gui over to mne-gui-addons and add tfr gui example (mne-tools#11616)
  MAINT: Add token [ci skip] (mne-tools#11622)
  API: One cycle of backward compat (mne-tools#11621)
  MAINT: Use git rather than zipball (mne-tools#11620)
  ENH: Speed up code a bit (mne-tools#11614)
  [BUG, MRG] Don't modify info in place for transform points (mne-tools#11612)
  [BUG, MRG] Fix topomap extra plot generated, add util to check a range (mne-tools#11607)
  ENH: Add mne-bids-pipeline to mne sys_info (mne-tools#11606)
  MAINT: `coding: utf-8` is implicit in Python 3 (mne-tools#11599)
  ENH: Read eyetracking data (Eyelink) (Fork of mne-tools#10855 ) (mne-tools#11152)
  MAINT: In Python 3, do not prefix literals with `u` (mne-tools#11604)
  MAINT: object is an implicit base for all classes (mne-tools#11601)
  ...
larsoner added a commit to georgeoneill/mne-python that referenced this pull request Apr 21, 2023
@larsoner
Merge remote-tracking branch 'upstream/main' into hfc
c55101f 
* upstream/main:
  BUG: Fix bug with paths (mne-tools#11639)
  MAINT: Report download time and size (mne-tools#11635)
  MRG: Allow retrieval of channel names via make_1020_channel_selections() (mne-tools#11632)
  Fix index name in to_data_frame()'s docstring (mne-tools#11457)
  MAINT: Use VTK prerelease wheels in pre jobs (mne-tools#11629)
  ENH: Allow gradient compensated data in maxwell_filter (mne-tools#10554)
  make test compatible with future pandas (mne-tools#11625)
larsoner added a commit to larsoner/mne-python that referenced this pull request Apr 25, 2023
@larsoner
Merge remote-tracking branch 'upstream/main' into cola5
7c44d72 
* upstream/main: (152 commits)
  FIX: missing channels/fiducials can be np.nan (mne-tools#11634)
  use py3.10 in precommit config (mne-tools#11648)
  MAINT: Unify GH Actions pytest (mne-tools#11644)
  MRG: Rename "Discourse" link in top navigation to "Forum" [ci skip] (mne-tools#11649)
  ENH: Add support for Harmonic Field correction (mne-tools#11536)
  Add pre-commit (mne-tools#11541)
  BUG: Fix bug with paths (mne-tools#11639)
  MAINT: Report download time and size (mne-tools#11635)
  MRG: Allow retrieval of channel names via make_1020_channel_selections() (mne-tools#11632)
  Fix index name in to_data_frame()'s docstring (mne-tools#11457)
  MAINT: Use VTK prerelease wheels in pre jobs (mne-tools#11629)
  ENH: Allow gradient compensated data in maxwell_filter (mne-tools#10554)
  make test compatible with future pandas (mne-tools#11625)
  Display SVG figures correctly in Report (mne-tools#11623)
  API: Port ieeg gui over to mne-gui-addons and add tfr gui example (mne-tools#11616)
  MAINT: Add token [ci skip] (mne-tools#11622)
  API: One cycle of backward compat (mne-tools#11621)
  MAINT: Use git rather than zipball (mne-tools#11620)
  ENH: Speed up code a bit (mne-tools#11614)
  [BUG, MRG] Don't modify info in place for transform points (mne-tools#11612)
  ...
larsoner added a commit to larsoner/mne-python that referenced this pull request Apr 25, 2023
@larsoner
Merge remote-tracking branch 'upstream/main' into kernel
bbc55af 
* upstream/main: (117 commits)
  FIX: missing channels/fiducials can be np.nan (mne-tools#11634)
  use py3.10 in precommit config (mne-tools#11648)
  MAINT: Unify GH Actions pytest (mne-tools#11644)
  MRG: Rename "Discourse" link in top navigation to "Forum" [ci skip] (mne-tools#11649)
  ENH: Add support for Harmonic Field correction (mne-tools#11536)
  Add pre-commit (mne-tools#11541)
  BUG: Fix bug with paths (mne-tools#11639)
  MAINT: Report download time and size (mne-tools#11635)
  MRG: Allow retrieval of channel names via make_1020_channel_selections() (mne-tools#11632)
  Fix index name in to_data_frame()'s docstring (mne-tools#11457)
  MAINT: Use VTK prerelease wheels in pre jobs (mne-tools#11629)
  ENH: Allow gradient compensated data in maxwell_filter (mne-tools#10554)
  make test compatible with future pandas (mne-tools#11625)
  Display SVG figures correctly in Report (mne-tools#11623)
  API: Port ieeg gui over to mne-gui-addons and add tfr gui example (mne-tools#11616)
  MAINT: Add token [ci skip] (mne-tools#11622)
  API: One cycle of backward compat (mne-tools#11621)
  MAINT: Use git rather than zipball (mne-tools#11620)
  ENH: Speed up code a bit (mne-tools#11614)
  [BUG, MRG] Don't modify info in place for transform points (mne-tools#11612)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agramfort agramfort agramfort approved these changes

@drammock drammock drammock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make_1020_channel_selections should have option to get names (not just indices)
3 participants
@hoechenberger @agramfort @drammock