WIP [FIX] BabyMeg HPI Fitting #800
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #800 +/- ##
==========================================
+ Coverage 29.47% 29.52% +0.05%
==========================================
Files 449 450 +1
Lines 39179 39296 +117
==========================================
+ Hits 11548 11603 +55
- Misses 27631 27693 +62
|
|
@RDoerfel could you have a look at this conflicts? if not, let me know please. Thx |
I think this PR will be obsolete once I refactored the HPI fitting. I'll close it once I'm there. |
|
Ok. No rush. |
|
obsolete with #884 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #773 resubmitted.
This PR tries to fix the ongoing problems with the BabyMeg HPI fitting. After quite a lot of debugging and desperate nights, I was able to fix some stuff and get at least stable fits, also with a 'high' error. The fits are quite stable around 10 mm displacement error.
Nevertheless, this is still more than with the old 42ce89b version before any changes were introduced. Besides a lot of other things, I also ended up copying the entire old HPI class and embed it into the current version. The results were as bad as with the most recent version. From that, I conclude that the problem was introduced with the new HPI plugin and I would suggest checking what is the difference between the way the HPI plugin and former
rthpisandHPIView.This brings us to what is yet in this PR:
HPI Fitting Class:
HPI Plugin:
That's it so far. I'm still not sure what will fix it entirely. It must be something that only affects the BabyMeg, since the VectorView fits are running like a charm. Also, the good results with the current versions are only obtained using the advanced model, and not the fast version.