Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Adding eye tracking to ch map #1344

Merged
merged 2 commits into from
Nov 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CITATION.cff
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,10 @@ authors:
family-names: Turner
affiliation: 'Wu Tsai Neurosciences Institute, Stanford University'
orcid: 'https://orcid.org/0000-0001-8639-9769'
- given-names: Christian
family-names: O'Reilly
affiliation: 'Computer Science and Engineering, University of South Carolina'
orcid: 'https://orcid.org/0000-0002-3149-4934'
- given-names: Alexandre
family-names: Gramfort
affiliation: 'Université Paris-Saclay, Inria, CEA, Palaiseau, France'
Expand Down
1 change: 1 addition & 0 deletions doc/authors.rst
Original file line number Diff line number Diff line change
Expand Up @@ -51,3 +51,4 @@
.. _Tom Donoghue: https://github.com/TomDonoghue
.. _William Turner: https://bootstrapbill.github.io/
.. _Yorguin Mantilla: https://github.com/yjmantilla
.. _Christian O'Reilly: https://github.com/christian-oreilly
5 changes: 3 additions & 2 deletions doc/whats_new.rst
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Version 0.17 (unreleased)

The following authors contributed for the first time. Thank you so much! 🤩

* Nobody yet
* `Christian O'Reilly`_

The following authors had contributed before. Thank you for sticking around! 🤘

Expand All @@ -29,7 +29,8 @@ Detailed list of changes
🚀 Enhancements
^^^^^^^^^^^^^^^

- Nothing yet
- :func:`mne_bids.write_raw_bids()` can now handle mne `Raw` objects with `eyegaze` and `pupil` channels, by `Christian O'Reilly`_ (:gh:`1344`)


🧐 API and behavior changes
^^^^^^^^^^^^^^^^^^^^^^^^^^^
Expand Down
6 changes: 6 additions & 0 deletions mne_bids/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,9 @@ def _get_ch_type_mapping(fro="mne", to="bids"):
ias="MEGOTHER",
syst="MEGOTHER",
exci="MEGOTHER",
# Eye tracking
eyegaze="EYEGAZE",
pupil="PUPIL",
)

elif fro == "bids" and to == "mne":
Expand All @@ -110,6 +113,9 @@ def _get_ch_type_mapping(fro="mne", to="bids"):
VEOG="eog",
HEOG="eog",
DBS="dbs",
# Eye tracking
EYEGAZE="eyegaze",
PUPIL="pupil",
)
else:
raise ValueError(
Expand Down