-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rest condition should have task name starting with rest not == to rest #585
Conversation
On the one hand, I agree we're currently being too strict. On the other hand, we might produce false-positives here. Imagine a task I'm starting to think we should introduce a config option, allowing the user to specify whether the data at hand is a resting-state recording or not. WDYT? |
yes I think you are right. How would you write such an option @hoechenberger ? |
Since we currently only allow to process a single task, we could simply have task_is_resting_state: bool = False Super low-effort and not very flexible, but I think absolutely sufficient for now. WDYT? |
Maybe better: task_is_resting_state: Optional[bool] = None and if |
looks pretty ok https://output.circle-artifacts.com/output/job/27fa0c6f-01aa-4c51-8044-aaf015d4bdff/artifacts/0/site/examples/ds003775.html ! this one is ready for review @hoechenberger 🙏 |
@hoechenberger please have a look at this one when you have a moment. 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nitpicks, otherwise LGTM!
Thanks @agramfort!!! |
ok for you @sappelhoff @hoechenberger ?
see at https://bids-specification.readthedocs.io/en/stable/04-modality-specific-files/01-magnetic-resonance-imaging-data.html
The task label included in the file name is derived from this "TaskName" field by removing all non-alphanumeric ([a-zA-Z0-9]) characters. For example "TaskName" "faces n-back" will correspond to task label facesnback. A RECOMMENDED convention is to name resting state task using labels beginning with rest.