-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift 3 Changes #47
base: master
Are you sure you want to change the base?
Swift 3 Changes #47
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, just run swiftlint to adjust the spacing and indention.
didSet{ | ||
redrawTable() | ||
} | ||
} | ||
/// The strings to be shown on as suggestions, setting the value of this automatically reload the tableview | ||
public var autoCompleteStrings:[String]?{ | ||
open var autoCompleteStrings:[String]?{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing space open var autoCompleteStrings:[String]? {
self.clearButtonMode = .Always | ||
self.addTarget(self, action: "textFieldDidChange", forControlEvents: .EditingChanged) | ||
self.addTarget(self, action: "textFieldDidEndEditing", forControlEvents: .EditingDidEnd) | ||
autoCompleteAttributes = [NSForegroundColorAttributeName:UIColor.black] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess no need to mentioned UIColor just .black
} | ||
else{ | ||
cell?.textLabel?.font = autoCompleteTextFont | ||
cell?.textLabel?.textColor = autoCompleteTextColor | ||
cell?.textLabel?.text = autoCompleteStrings![indexPath.row] | ||
cell?.textLabel?.text = autoCompleteStrings![(indexPath as NSIndexPath).row] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it IndexPath
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please update if on swift 3. How I can i Download from pull request?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I have converted in swift 3 and implemented in my code
Thanks
No description provided.