Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow $ref to be used as a schema property #250

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

mnahkies
Copy link
Owner

The SCIM v2 RFC includes a property named $ref on group membership, etc

Eg:
https://datatracker.ietf.org/doc/html/rfc7643

{
            "name" : "$ref",
            "type" : "reference",
            "referenceTypes" : [
              "User",
              "Group"
            ],
            "multiValued" : false,
            "description" : "The URI of the corresponding 'Group'
resource to which the user belongs.",
            "required" : false,
            "caseExact" : false,
            "mutability" : "readOnly",
            "returned" : "default",
            "uniqueness" : "none"
          },

Previously we were naively trying to resolve any $ref key we found as an OpenAPI reference

Now we still naively do this, but only if it quacks like a real $ref

@mnahkies mnahkies enabled auto-merge (squash) September 29, 2024 12:45
@mnahkies mnahkies merged commit 9c09191 into main Sep 29, 2024
2 checks passed
@mnahkies mnahkies deleted the mn/fix/-is-valid-property branch September 29, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant