feat: add e2e test suite #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnahkies
force-pushed
the
mn/feat/e2e-tests
branch
from
67b6581 to
a4597e6
Compare
mnahkies
changed the base branch from
main
to
mn/fix/allow-number-array-query-param
mnahkies
added a commit
that referenced
this pull request
Aug 17, 2024
(identified whilst adding e2e tests in #235 🙃)
mnahkies
force-pushed
the
mn/feat/e2e-tests
branch
from
bbc1233 to
a130faa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, whilst some of the unit tests execute specific pieces of generated code using the
node:vmmodule, and the integration tests check that typescript is happy to build the code, we haven't had very comprehensive end-to-end tests in the repo.This has meant manually checking changes in other (mostly private) projects, which is a bit of a pain and not very transparent.
This PR aims to add end to end tests that actually run a koa service, and make calls to it using a generated client. Coverage will be relatively low to begin with and iteratively improved on over time.
It will hopefully also serve as a decent sample of what a service using this project might look like.