improve:adjust xr begin/end render frame call's position (cocos#16021)

(Calculate the correct delta time)
mmyduckx · Aug 18, 2023 · 56417f3 · 56417f3
1 parent 92c37fc
commit 56417f3
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/native/cocos/engine/Engine.cpp b/native/cocos/engine/Engine.cpp
@@ -206,6 +206,7 @@ void Engine::destroy() {
 
 int32_t Engine::run() {
     BasePlatform *platform = BasePlatform::getPlatform();
+    _xr = CC_GET_XR_INTERFACE();
     platform->runInPlatformThread([&]() {
         tick();
     });
@@ -284,15 +285,15 @@ void Engine::tick() {
 #endif
 
         prevTime = std::chrono::steady_clock::now();
-
+        if (_xr) _xr->beginRenderFrame();
         _scheduler->update(dt);
 
         se::ScriptEngine::getInstance()->handlePromiseExceptions();
         events::Tick::broadcast(dt);
         se::ScriptEngine::getInstance()->mainLoopUpdate();
 
         cc::DeferredReleasePool::clear();
-
+        if (_xr) _xr->endRenderFrame();
         now = std::chrono::steady_clock::now();
         dtNS = dtNS * 0.1 + 0.9 * static_cast<double>(std::chrono::duration_cast<std::chrono::nanoseconds>(now - prevTime).count());
         dt = static_cast<float>(dtNS) / NANOSECONDS_PER_SECOND;

diff --git a/native/cocos/engine/Engine.h b/native/cocos/engine/Engine.h
@@ -48,6 +48,7 @@ class DebugRenderer;
 class Profiler;
 class BuiltinResMgr;
 class ProgramLib;
+class IXRInterface;
 
 #define NANOSECONDS_PER_SECOND 1000000000
 #define NANOSECONDS_60FPS      16666667L
@@ -132,6 +133,8 @@ class CC_DLL Engine : public BaseEngine {
     events::WindowEvent::Listener _windowEventListener;
 
     CC_DISALLOW_COPY_MOVE_ASSIGN(Engine);
+
+    IXRInterface *_xr{nullptr};
 };
 
 } // namespace cc
diff --git a/native/cocos/platform/android/AndroidPlatform.cpp b/native/cocos/platform/android/AndroidPlatform.cpp
@@ -843,9 +843,7 @@ int32_t AndroidPlatform::loop() {
         if (xr && !xr->platformLoopStart()) continue;
         _inputProxy->handleInput();
         if (_inputProxy->isAnimating() && (xr ? xr->getXRConfig(xr::XRConfigKey::SESSION_RUNNING).getBool() : true)) {
-            if (xr) xr->beginRenderFrame();
             runTask();
-            if (xr) xr->endRenderFrame();
             if (_inputProxy->isActive()) {
                 flushTasksOnGameThreadAtForegroundJNI();
             }