Fix TreeExplainer instanciation when a tree in LightGBM Classifier model has n_features_in_tree = 1 #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @CharlesCousyn, thank you so much for taking care of this! This is very appreciated! One quick thing. Would you be able to add a very small unit test as a minimal example that would error in the current version without your fix but succeeds with your fix? This way the fix is future proof? I think it would be good if the TreeExplainer is used to explain a very small "model" with only one feature. For this you could use a Custom Tree (here is some info on the custom tree: https://shapiq.readthedocs.io/en/latest/notebooks/tree_notebooks/treeshapiq_custom_tree.html). Best Max! |
mmschlk
requested changes
Jan 31, 2025
|
@mmschlk Done! |
Amazing! I will check it out and merge it! :) Thank you again! :) |
mmschlk
approved these changes
Feb 5, 2025
|
This PR fixes and closes #286 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I am opening this PR to fix the bug mentioned here for the TreeExplainer.
Let me know id it does fix the problem correctly!