Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update float.h "# else // GPU" comments #464

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

anthonydito
Copy link
Contributor

This confused me for a couple minutes, so thought I would throw up a PR to update these comments.

#ifdef PBRT_IS_GPU_CODE
< GPU Code >
#else  // GPU
< CPU Code >
#endif

I think the comment next to the else is supposed to say "CPU" since that is the block that is happening here.

#ifdef PBRT_IS_GPU_CODE
< GPU Code >
#else  // CPU
< CPU Code >
#endif

This PR simply updates those comments.

These # else comments were not what I expected. This commit updates the to say "CPU"
@mmp
Copy link
Owner

mmp commented Nov 30, 2024

Yep, that's better-thanks!

@mmp mmp merged commit 88645ff into mmp:master Nov 30, 2024
@anthonydito anthonydito deleted the gpu-comment-fix branch November 30, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants