-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PlayCanvas + Standalone Viewer #205
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcusLongmuir
force-pushed
the
feature/playcanvas+viewer
branch
from
November 5, 2024 12:16
abe75b0
to
948d4c4
Compare
🪓 PR closed, deleted preview at https://github.com/mml-io/mml/tree/gh-pages/pull/205/ |
MarcusLongmuir
force-pushed
the
feature/playcanvas+viewer
branch
3 times, most recently
from
November 5, 2024 16:16
3597b79
to
03bc90a
Compare
MarcusLongmuir
force-pushed
the
feature/playcanvas+viewer
branch
from
November 5, 2024 16:31
03bc90a
to
c0e3ef4
Compare
} | ||
|
||
if (value.indexOf("rgba(") === 0) { | ||
const rgba = /^rgba\((\d+),\s*(\d+),\s*(\d+),\s*(\d*\.?\d+)\)$/.exec(value); |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data High
This that depends on may run slow on strings starting with 'rgba(0,0,0,' and with many repetitions of '0'.
This that depends on library input may run slow on strings starting with 'rgba(0,0,0,' and with many repetitions of '0'.
regular expression
Error loading related location
Loading library input
Error loading related location
Loading This
regular expression
Error loading related location
Loading
MarcusLongmuir
force-pushed
the
feature/playcanvas+viewer
branch
from
November 28, 2024 16:37
aa028dd
to
54aeab1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #170, resolves #207, resolves #192
This PR is a significant overhaul of the frontend packages with the overall goals of:
The major change is that there is now an indirection between the implementation of the attribute handling of MML elements (e.g.
m-cube
) and the particular rendering/graphics engine (e.g. ThreeJS).This results in new packages that separate the concerns.
@mml-io/mml-web
contains the networking and attribute handling@mml-io/mml-web-threejs
contains the per-element implementations of graphics for ThreeJS@mml-io/mml-web-threejs-standalone
contains an implementation of a standalone ThreeJS app that renders MML.What kind of changes does your PR introduce? (check at least one)
Does your PR introduce a breaking change? (check one)
If yes, please describe its impact and migration path for existing applications:
Any users of the
mml-web
package should now depend on the@mml-io/mml-web
package and@mml-io/mml-web-three-standalone
.The
MMLScene
now takes an element as a constructor argument and requires initialising with a graphics adapter:Does your PR fulfill the following requirements?