Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parent node id remapping (#198) #199

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Conversation

MarcusLongmuir
Copy link
Collaborator

@MarcusLongmuir MarcusLongmuir commented Sep 3, 2024

This PR fixes an issue where parent node ids were being incorrectly attempted to be remapped when resolving changes to target elements. The node ids that were being used were already remapped so this remapping looking was incorrect.

This issue was rather difficult to hit as you would need to:

  • Reload a document
  • Have the diff between the documents result in remapping node ids
  • Cause a mutation to an element whose parent id collided with one of the remapped ids (even if the change itself was nothing to do with the nodes that were actually remapped)

A regression test that was used to root cause the issue has been added.


What kind of changes does your PR introduce? (check at least one)

  • Bugfix

Does your PR introduce a breaking change? (check one)

  • No

Does your PR fulfill the following requirements?

  • All tests are passing
  • The title references the corresponding issue # (if relevant)

@MarcusLongmuir MarcusLongmuir merged commit 4730cf4 into main Sep 3, 2024
8 checks passed
@MarcusLongmuir MarcusLongmuir deleted the bugfix/198-remapped-node branch September 3, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants