Enable CG detection in the job templates (dotnet#8376) (dotnet#8403)

* Enable CG detection in the job templates (dotnet#8376)

Remove the explicit injection in the arcade pipeline

* Continue on error for CG

eng/common/templates/job/job.yml

@@ -25,6 +25,7 @@ parameters:
   enablePublishTestResults: false
   enablePublishUsingPipelines: false
   useBuildManifest: false
+  disableComponentGovernance: false
   mergeTestResults: false
   testRunTitle: ''
   name: ''
@@ -136,6 +137,10 @@ jobs:
         richNavLogOutputDirectory: $(Build.SourcesDirectory)/artifacts/bin
       continueOnError: true
 
+  - ${{ if and(eq(parameters.runAsPublic, 'false'), ne(variables['System.TeamProject'], 'public'), notin(variables['Build.Reason'], 'PullRequest'), ne(parameters.disableComponentGovernance, 'true')) }}:
+      - task: ComponentGovernanceComponentDetection@0
+        continueOnError: true
+
   - ${{ if eq(parameters.enableMicrobuild, 'true') }}:
     - ${{ if and(eq(parameters.runAsPublic, 'false'), ne(variables['System.TeamProject'], 'public'), notin(variables['Build.Reason'], 'PullRequest')) }}:
       - task: MicroBuildCleanup@1

eng/common/templates/job/publish-build-assets.yml

@@ -37,10 +37,6 @@ jobs:
     - name: _BuildConfig
       value: ${{ parameters.configuration }}
     - group: Publish-Build-Assets
-    # Skip component governance and codesign validation for SDL. These jobs
-    # create no content.
-    - name: skipComponentGovernanceDetection
-      value: true
     - name: runCodesignValidationInjection
       value: false
 

eng/common/templates/jobs/jobs.yml

@@ -7,7 +7,11 @@ parameters:
 
   # Optional: Enable publishing using release pipelines
   enablePublishUsingPipelines: false
-
+
+  # Optional: Disable component governance detection. In general, component governance
+  # should be on for all jobs. Use only in the event of issues.
+  disableComponentGovernance: false
+
   graphFileGeneration:
     # Optional: Enable generating the graph files at the end of the build
     enabled: false

eng/common/templates/post-build/common-variables.yml

@@ -91,9 +91,5 @@ variables:
   - name: InternalInstallersBlobFeedKey
     value: $(dotnetclimsrc-access-key)
 
-  # Skip component governance and codesign validation for SDL. These jobs
-  # create no content.
-  - name: skipComponentGovernanceDetection
-    value: true
   - name: runCodesignValidationInjection
     value: false