Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated dependency jekyll-algolia #4958

Closed
wants to merge 1 commit into from

Conversation

alouiadel
Copy link
Contributor

This is a documentation change.

Summary

Removed mentioning of now deprecated jekyll-algolia gem from documentation
i also suggest you check : mmistakes/mm-github-pages-starter#59

Context

Is this related to any GitHub issue(s)?
No, i had to setup my personal website using this template , this is how i encountered this.

@iBug
Copy link
Collaborator

iBug commented Aug 20, 2024

Algolia is still one of the best search providers out there. If you remove jekyll-algolia, consider documenting its successor gem instead.

@alouiadel
Copy link
Contributor Author

It seems that no alternative gem is available since Jekyll isn't popular enough to encourage API providers to create these gems. However, I view keeping a deprecated gem active as a vulnerability and a security concern for the template users

@iBug
Copy link
Collaborator

iBug commented Aug 20, 2024

Since Algolia integration remains a stood-out feature of the theme, I prefer keeping the documentation or one of its substitutes in place, until the status quo stops working altogether.

Also, I don't consider a deprecated gem "a vulnerability" in a static site generator until proven to be dangerous. Deprecation only means it'll stop being maintained, not being taken over by hostile parties.

@alouiadel
Copy link
Contributor Author

ok fair enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants