Extra space added when using a feature_row

[lsolesen]

Extra space added when using a feature_row in layout single.

Environment

• Minimal Mistakes version: 4.17.2
• Ruby gem or remote theme version:
• Jekyll version:
• Git repository URL: https://github.com/motionsplan/motionsplan-dk-jekyll/blob/gh-pages/_posts/2019-11-19-regler-styrkeloft.md
• GitHub Pages hosted (if yes provide URL to site):
• Operating system:

Expected behavior

There should be no extra space in front of the feature row.

Steps to reproduce the behavior

See https://github.com/motionsplan/motionsplan-dk-jekyll/blob/gh-pages/_posts/2019-11-19-regler-styrkeloft.md

Which gives this result:

Other

It can be seen on the live site here: https://www.motionsplan.dk/powerlifting-rules/

[mmistakes]

Looks like it has to do with the right sidebar. If you inspect it you can see it's pushing over into the main content column some, which pushes the feature row down.

When the right sidebar isn't being floated the feature row has enough room and fits.

Not sure what the fix is yet.

[iBug]

Duplicate of #2263

The answer is, if you want to use that in single layout, you should look into gallery instead. feature_row is intended for splash layout.

[mmistakes]

It'll likely break other things but giving feature__wrapper an inline style of display: inline-block fixes the wrap with the sidebar.

[iBug]

@mmistakes Perhaps something like this would be helpful without breaking anything?

.layout--single .feature__wrapper {
  display: inline-block;
}

Tried this in a few MM-themed sites, didn't notice any failure so far.

[mmistakes]

@iBug that change looks harmless to me if you want to submit a PR with the fix.