Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON Feed #1035

Closed
justinrummel opened this issue May 26, 2017 · 6 comments
Closed

JSON Feed #1035

justinrummel opened this issue May 26, 2017 · 6 comments

Comments

@justinrummel
Copy link
Contributor

Didn't know if you would be interested in a JSON feed added to this repo. I don't believe the PR for jekyll-feed is going to move forward, so it won't happen by a gem. And the one advertised for vallieres does not take into account some changes done by MM (such as images).

@mmistakes
Copy link
Owner

mmistakes commented May 26, 2017

Perhaps.

I've done mine own version of a JSON Feed layout. Still want to switch to jekyll-seo-tag plugin and standardize on the use of page.image or page.image.feed instead of page.image.feature to better leverage the official Jekyll plugins that use those variables.

@justinrummel
Copy link
Contributor Author

Gotcha... if there is going to be changes in the future then people can view my repo and use it if they want, but it may be better to wait till those elements calm down.

@justinrummel
Copy link
Contributor Author

qq on use of liquid to parse data, why is it necessary to put the tags in a for loop. Since this is already an array of tags, can you simply state:

"tags" : {{ post.tags | jsonify }}

better yet, I would sort and ensure the array is unique.

@mmistakes
Copy link
Owner

Good question. Just a miss when I forked the layout.There were a few other things I simplified and removed. Dropping the for loop should improve build times slightly too.

sort and uniq are good ideas as well.

@rriemann
Copy link
Contributor

rriemann commented Aug 9, 2017

Any progress on this? @justinrummel, have you prepared a PR?

@mmistakes
Copy link
Owner

mmistakes commented Aug 9, 2017

Closing as I don't really have any interest in managing a layout for this. My concerns are all echo'd here jekyll/jekyll-feed#172

Your best bet is looking for a plugin/gem that does this or rolling your own layout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants