Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans to support JSON Feed? #172

Closed
reefdog opened this issue May 17, 2017 · 20 comments
Closed

Plans to support JSON Feed? #172

reefdog opened this issue May 17, 2017 · 20 comments

Comments

@reefdog
Copy link

reefdog commented May 17, 2017

JSON Feed was just announced. Assuming it has any legs—Manton and Brent are no lightweights—it might stick around. Is it reasonable to expect jekyll-feed to one day support it alongside Atom, or should a new plugin be developed?

Either way, I'm keen to help develop support. Just wondering if it belongs in a new plugin or as a configurable option for this one.

@pathawks
Copy link
Member

I can't speak for @benbalter, but I have no plans at this point.

If there were a compelling advantage, we could take another look. I am very excited about the technology, but I think we need to be conservative about what we add.

From the JSON Feed spec:

Any publisher already publishing RSS and/or Atom should continue to do so. In fact, if you’re trying to decide which format (of RSS, Atom, and JSON Feed) to use, and you can do only one, pick RSS — it’s time-tested, popular, and good.

@benbalter
Copy link
Contributor

I'm with @pathawks on this one. If we add it now, we have to support it in perpetuity, even if consumers don't adopt it.

That said, we may be able to move some of the template logic to a drop like we did for SEO tag (creating shared field values), and allow another plugin to consume those calculated fields.

@reefdog
Copy link
Author

reefdog commented May 17, 2017

Sensible position. Thanks, both! (Feel free to close this or leave it open as a signpost, as you see fit.)

@pathawks
Copy link
Member

If we did support JSON Feed, we would want to build the feed in Ruby rather than Liquid (like what SEO Tag now does for JSON-LD).

Closing for now, but if there were a compelling use case I really would love to add support. Will keep an eye on this.

@pathawks
Copy link
Member

That said, we may be able to move some of the template logic to a drop like we did for SEO tag (creating shared field values), and allow another plugin to consume those calculated fields.

@benbalter I wonder how much shared logic there is between jekyll-feed and jekyll-seo. I wonder if it would make any sense at all to abstract some of that logic into a separate gem?

@parkr
Copy link
Member

parkr commented May 18, 2017

I'm really jazzed about this project and would love to see JSON Feed supported. Could we reconsider this? Would it make more sense to ship as a separate plugin, e.g. jekyll-feed-json?

@parkr parkr reopened this May 18, 2017
@pathawks
Copy link
Member

Maybe we 🎄 and if a site specifies a path in site.feed.json_path we can enable JSON Feed output?

There is enough shared logic that it would be a shame to duplicate everything in a second gem.

FWIW, Gruber is making me more excited for JSON Feed as well.

@parkr
Copy link
Member

parkr commented May 19, 2017

Maybe we 🎄 and if a site specifies a path in site.feed.json_path we can enable JSON Feed output?

I think defaulting this to false would be a good way to go about doing this for the first iteration or two. If, in a few months, this thing hasn't gone away, then we can default it to true and give everyone Better Feeds™️.

@mattr-
Copy link
Member

mattr- commented May 19, 2017

Based on https://ndarville.com/blog/2017/05/19/json-feed-for-jekyll/ I think we're better off leaving out support for JSON feed for now.

@parkr
Copy link
Member

parkr commented May 20, 2017

The layout is imperfect at best. I plopped it into my site and i had to fix all sorts of things because quotes & HTML borked it up. There is no Liquid replacement for JSON.generate.

@mattr-
Copy link
Member

mattr- commented May 20, 2017

There is no Liquid replacement for JSON.generate.

No doubt. But it seems good enough for now, which gives us the ability to see how JSON feed adaption progresses and how the "standard" develops. I see no reason for us to add support that we have to maintain in near perpetuity for a 2 day old spec.

@mryellow
Copy link

mryellow commented Jun 6, 2017

If there were a compelling advantage

Pulling post lists with Javascript into SPA.

Parsing XML is old-hat.

@mryellow
Copy link

mryellow commented Jun 7, 2017

Just whipped up this modified version which does JSON and JSON only if anyone needs it.

https://github.com/mryellow/jekyll-feed-json

@ghost
Copy link

ghost commented Jun 22, 2017

I wish I were as objective as others, but this is the first I've heard of JSON Feed and my gut tells me it's an awful, awful idea. Here's why:

  • JSON, while lightweight, is not at all forgiving. When you have a syntax issue, even a misplaced comma, everything fails. For proper health the WWW should be distributed and its technologies resilient. If I were adopting a new feed syntax personally I'd choose TOML before JSON.
  • Putting markup inside JSON oh boy. I don't even know where to begin. Jeff Atwood was right.

Sure glad this was closed (at one point, at least)! D:

@reefdog
Copy link
Author

reefdog commented Jun 24, 2017

@JHabdas Arguing against supporting JSON Feed with this gem is reasonable, but you seem to be arguing against JSON as a format, which… I mean, that ship has sailed 'round the earth a few times. ;)

@parkr
Copy link
Member

parkr commented Jun 24, 2017

We'll watch the field and see whether JSON Feed is adopted. My feeling is that it's simple and universal enough to be easy to maintain and widely useful. I would ship it as an opt-in feature for this plugin, with XML being the standard for now.

@ghost
Copy link

ghost commented Jun 29, 2017

@parkr et. al I gave the JSONFeed repo two issues. Feel free to monitor them and weigh in with your expertise if you like.

@mattr-
Copy link
Member

mattr- commented Jun 29, 2017

There's now a separate json-feed plugin for jekyll. https://github.com/vallieres/jekyll-json-feed

@reefdog
Copy link
Author

reefdog commented Jun 29, 2017

@mattr That's not a plugin, that's just a template file, a solution succinctly argued against here.

Edit: Accidentally a word.

@jekyllbot
Copy link
Contributor

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

@parkr parkr closed this as completed Aug 29, 2017
@jekyll jekyll locked and limited conversation to collaborators Apr 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants