[DRAFT] [DNM] Suggestions for #10591 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aparajit-pratap
changed the title
aparajit-pratap
commented
Apr 26, 2020
| @@ -137,7 +137,7 @@ private void OnViewModelMessageLogged(ILogMessage msg) | |||
|
|
|||
| private void AddToSidebar(bool displayDefaultContent) | |||
| { | |||
| // verify the browser window has been initialised | |||
| // verify the browser window has been initialized | |||
aparajit-pratap
commented
Apr 26, 2020
| @@ -21,8 +21,6 @@ | |||
| src: url("fonts/ArtifaktElement-Regular.woff") format("woff"); | |||
| color: white; | |||
| background-color: #353535; | |||
| overflow-x: hidden; | |||
| overflow-y: hidden; | |||
aparajit-pratap
commented
Apr 26, 2020
| @@ -21,8 +21,6 @@ | |||
| src: url("fonts/ArtifaktElement-Regular.woff") format("woff"); | |||
| color: white; | |||
| background-color: #353535; | |||
| overflow-x: hidden; | |||
| overflow-y: hidden; | |||
aparajit-pratap
commented
Apr 26, 2020
| @@ -14,8 +14,6 @@ | |||
| src: url("fonts/ArtifaktElement-Regular.woff") format("woff"); | |||
| background-color: #353535; | |||
| padding: 1%; | |||
| overflow-x: hidden; | |||
| overflow-y: hidden; | |||
aparajit-pratap
commented
Apr 26, 2020
| @@ -307,7 +307,7 @@ public struct InfoBubbleDataPacket | |||
| public Point TopLeft; | |||
| public Point BotRight; | |||
| public string Text; | |||
| public Uri Link; | |||
| internal Uri Link; | |||
mmisol
pushed a commit
that referenced
this pull request
May 27, 2020
* Add Engine property to PythonNodeBase * Add engine selector dropdown to python editor * Add notification API to nodemodel * add warnings to resources * Add IronPython dialog on open saved workspace * Add Engine label on node * make LogNotification internal * python engine enum * Python migration extension DRAFT (#1) * Python migration extension DRAFT * update extension * small cleanup * move dialog and notification strings to extension resource * Update PythonMigrationViewExtension.cs * added python engine label to From String Node * add engine selector to python script from string node in context menu * Update EngineLabel.xaml * comment updates * Update Dynamo.All.sln * Update PythonMigrationViewExtension.cs * Update PythonMigrationViewExtension.cs * comment updates * Update Resources.Designer.cs * update csproj + small cleanup * added more information btn to IronPythonDialog * comment updates * tests added * tests * comment updates * Updates dialog, notification and documentationbrowser text * update tests * fix dialog box and small clean up * warning html update * updates to warning messages * Update PythonStringNode.cs Co-authored-by: Michael Dewberry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[DRAFT] Suggestions for DynamoDS#10591