Skip to content

Commit

Permalink
build: move CI to GitHub Actions
Browse files Browse the repository at this point in the history
Reduce CI time by moving to GitHub Actions.

Fixes: nodejs#312
  • Loading branch information
mmarchini committed Nov 7, 2019
1 parent ec01604 commit d2ffb1b
Show file tree
Hide file tree
Showing 3 changed files with 60 additions and 151 deletions.
54 changes: 54 additions & 0 deletions .github/workflows/push.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
name: on push or pull_request

on:
push:
branches:
- master
pull_request:

jobs:
build:
runs-on: ${{ matrix.os }}

strategy:
matrix:
node-version: [8.x]
os: [ubuntu-latest]
# node-version: [8.x, 10.x, 11.x]
# os: [ubuntu-latest, macos-latest]
steps:
- uses: actions/checkout@v1
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- name: install dependencies Linux
if: matrix.os == 'ubuntu-latest'
run: |
sudo apt-get -qq update
sudo apt-get install lldb-3.9 liblldb-3.9-dev lcov gdb -y
sudo cat /usr/share/apport/apport
- name: install npm dependencies
run: npm install --llnode_build_addon=true --llnode_coverage=true
- name: npm install, build, and test
run: TEST_LLNODE_DEBUG=1 LLNODE_DEBUG=1 TEST_LLDB_BINARY=`which lldb-3.9` npm run nyc-test-all
- name: coverage
run: |
npm run coverage
npm run codecov-upload
env:
CI: true
# linter:
# runs-on: [ubuntu-latest]
# steps:
# - uses: actions/checkout@v1
# - name: Use Node.js LTS
# uses: actions/setup-node@v1
# with:
# node-version: 12.x
# - name: npm install, build, and test
# run: |
# sudo apt-get -qq update
# sudo apt-get install lldb-3.9 liblldb-3.9-dev lcov -y
# npm install
# npm run linter
147 changes: 0 additions & 147 deletions .travis.yml

This file was deleted.

10 changes: 6 additions & 4 deletions test/common.js
Original file line number Diff line number Diff line change
Expand Up @@ -247,12 +247,14 @@ function spawnWithTimeout(cmd, cb) {
}

function saveCoreLinux(executable, scenario, core, cb) {
const cmd = `ulimit -c unlimited && ${executable} ` +
`--abort_on_uncaught_exception --expose_externalize_string ` +
`${path.join(exports.fixturesDir, scenario)}; `;
// const cmd = `ulimit -S -c unlimited && ulimit -H -c unlimited && ` +
// `--abort_on_uncaught_exception --expose_externalize_string ` +
// `; `;
const cmd = `gdb ${executable} --batch -ex 'run --abort-on-uncaught-exception --expose-externalize-string ${path.join(exports.fixturesDir, scenario)}' -ex 'generate-core-file ${core}'`
spawnWithTimeout(cmd, () => {
cb()
// FIXME (mmarchini): Should also handle different core system settings.
spawnWithTimeout(`mv ./core ${core}`, cb);
// spawnWithTimeout(`find . -name core && mv ./core ${core}`, cb);
});
}

Expand Down

0 comments on commit d2ffb1b

Please sign in to comment.